From 4562612640d21513ca17bf576fe5181efa9739eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sabri=20=C3=9Cnal?= Date: Mon, 1 Apr 2024 19:12:04 +0300 Subject: [PATCH 1/3] appdata: `translate=no` properties It appears that the appstream project no longer supports `translatable=no` properties, and gettext extract them as translatable. I opened an issue to inform about the situation, but `translatable=no` properties are not accepted by developers. You can find the issue here: `/~https://github.com/ximion/appstream/issues/623` **Please test your script or string extraction process before merging this PR.** > In MetaInfo files, each individual paragraph of a description > (or enumerated entry) is translated individually, however, > you can only exclude the complete block from being translated > by adding `translate="no"` to the description element. Source: https://freedesktop.org/software/appstream/docs/sect-Quickstart-Translation.html --- data/app.drey.PaperPlane.metainfo.xml.in.in | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/data/app.drey.PaperPlane.metainfo.xml.in.in b/data/app.drey.PaperPlane.metainfo.xml.in.in index 986862c62..9f35d4eee 100644 --- a/data/app.drey.PaperPlane.metainfo.xml.in.in +++ b/data/app.drey.PaperPlane.metainfo.xml.in.in @@ -44,7 +44,7 @@ - +

This is the fifth beta release of Paper Plane 0.1.0 with new features and bug fixes:

  • Archived chats can now be displayed. (#598, #607, #613)
    • @@ -64,7 +64,7 @@ - +

    This is the fourth beta release of Paper Plane 0.1.0 with new features and bug fixes:

    • Paper Plane now uses some new shiny widgets from libadwaita 1.4, thanks to @melix99. (#518)
      • @@ -82,7 +82,7 @@ - +

      The third beta release of Paper Plane 0.1.0 should in the first place fix a build error on Flathub:

      • Added registered categories to the desktop file to fix a build error on Flathub.
        • @@ -92,7 +92,7 @@ - +

        The second beta release of Paper Plane 0.1.0 contains the following features, fixes and chores:

        • Blueprint compiler has been updated to version 0.8.1, thanks to @alissonlauffer.
          • @@ -106,7 +106,7 @@ - +

          Paper Plane 0.1.0-beta.1 is the first release for enthusiasts to try out and play around with.

                     @@ -119,7 +119,7 @@ ModernToolkit HiDpiIcon - Marco Melorio + Marco Melorio marco.melorio@protonmail.com @gettext-package@ @app-id@.desktop From bd3020b439dbf959e6c69512d74fe3b3807ab02e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sabri=20=C3=9Cnal?= Date: Mon, 1 Apr 2024 19:12:11 +0300 Subject: [PATCH 2/3] appdata: Add developer ID Flathub requires a developer tag and developer ID. Also Appstream decided to use rdns structure for developer ID. It allows reverse-dns IDs like sh.cozy, de.geigi or Fediverse handle (like @user@example.org) > A developer tag with a name child tag must be present. > Only one developer tag is allowed and the name tag also must be present only once in untranslated form. ``` Developer name ``` Source: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#name-summary-and-developer-name > The element should have a id property, containing a unique ID to identify the component developer / development team. It is recommended to use a reverse-DNS name, like org.gnome or io.github.ximion, or a Fediverse handle (like @user@example.org) as ID to achieve a higher chance of uniqueness. Source: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer --- data/app.drey.PaperPlane.metainfo.xml.in.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/data/app.drey.PaperPlane.metainfo.xml.in.in b/data/app.drey.PaperPlane.metainfo.xml.in.in index 9f35d4eee..df8074cb7 100644 --- a/data/app.drey.PaperPlane.metainfo.xml.in.in +++ b/data/app.drey.PaperPlane.metainfo.xml.in.in @@ -120,6 +120,9 @@ HiDpiIcon Marco Melorio + + Marco Melorio + marco.melorio@protonmail.com @gettext-package@ @app-id@.desktop From ed8f08b537d8f37896e2b538fd7ce6cf073ff8bb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sabri=20=C3=9Cnal?= Date: Sat, 6 Apr 2024 00:26:07 +0300 Subject: [PATCH 3/3] ui: Fix translatable usage Marking translatable="yes" or translatable="1" actually achieves the same result, but almost all projects use the first one. It's good to follow common practices. --- src/ui/session/contacts_window/mod.ui | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ui/session/contacts_window/mod.ui b/src/ui/session/contacts_window/mod.ui index 8f53f3082..e0af217c0 100644 --- a/src/ui/session/contacts_window/mod.ui +++ b/src/ui/session/contacts_window/mod.ui @@ -1,6 +1,6 @@