Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-copy values in slotmap on stable 1.49 🎉 #46

Closed
Uriopass opened this issue Nov 25, 2020 · 2 comments
Closed

Non-copy values in slotmap on stable 1.49 🎉 #46

Uriopass opened this issue Nov 25, 2020 · 2 comments

Comments

@Uriopass
Copy link
Contributor

Uriopass commented Nov 25, 2020

With 1.49, ManuallyDrop in unions is coming on stable.

I see the code is already written using ManuallyDrop, which means that slotmap is already ready to be built on 1.49 and onwards! (I tested on beta)
However, it is currently under the unstable feature flag, which also enables the TryReserve API that, sadly, is not stable yet.

What should be the course of action to enable users to use non-copy types on stable?

I propose to remove the Slottable trait entirely and release a 0.5.0 version of the crate since this would break backward compatibility.

Another proposition would be to keep the unstable feature flag with the same semantics, and introduce a new flag to specifically enable non-copy types.

I'd be happy to do the PR whichever way you prefer.

@Uriopass Uriopass changed the title Non-copy values in slotmap on stable 1.49 (:tada:) Non-copy values in slotmap on stable 1.49 🎉 Nov 25, 2020
@Uriopass Uriopass changed the title Non-copy values in slotmap on stable 1.49 🎉 Non-copy values in slotmap on stable 1.49 🎉 Nov 25, 2020
@orlp
Copy link
Owner

orlp commented Nov 30, 2020

I'm waiting for the actual release before I do anything. Fear not, I will make slotmap require the least amount of features/dependencies as possible to function.

@orlp
Copy link
Owner

orlp commented Jan 1, 2021

This is implemented and will be in the next version coming out soon.

@orlp orlp closed this as completed Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants