You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I see the code is already written using ManuallyDrop, which means that slotmap is already ready to be built on 1.49 and onwards! (I tested on beta)
However, it is currently under the unstable feature flag, which also enables the TryReserve API that, sadly, is not stable yet.
What should be the course of action to enable users to use non-copy types on stable?
I propose to remove the Slottable trait entirely and release a 0.5.0 version of the crate since this would break backward compatibility.
Another proposition would be to keep the unstable feature flag with the same semantics, and introduce a new flag to specifically enable non-copy types.
I'd be happy to do the PR whichever way you prefer.
The text was updated successfully, but these errors were encountered:
Uriopass
changed the title
Non-copy values in slotmap on stable 1.49 (:tada:)
Non-copy values in slotmap on stable 1.49 🎉
Nov 25, 2020
Uriopass
changed the title
Non-copy values in slotmap on stable 1.49 🎉
Non-copy values in slotmap on stable 1.49 🎉
Nov 25, 2020
I'm waiting for the actual release before I do anything. Fear not, I will make slotmap require the least amount of features/dependencies as possible to function.
With 1.49, ManuallyDrop in
union
s is coming on stable.I see the code is already written using ManuallyDrop, which means that
slotmap
is already ready to be built on 1.49 and onwards! (I tested on beta)However, it is currently under the
unstable
feature flag, which also enables theTryReserve
API that, sadly, is not stable yet.What should be the course of action to enable users to use non-copy types on stable?
I propose to remove the Slottable trait entirely and release a 0.5.0 version of the crate since this would break backward compatibility.
Another proposition would be to keep the
unstable
feature flag with the same semantics, and introduce a new flag to specifically enable non-copy types.I'd be happy to do the PR whichever way you prefer.
The text was updated successfully, but these errors were encountered: