Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: cross-compile build issue #20549

Closed
hayzamjs opened this issue Feb 22, 2023 · 1 comment
Closed

node: cross-compile build issue #20549

hayzamjs opened this issue Feb 22, 2023 · 1 comment

Comments

@hayzamjs
Copy link

Maintainer: @nxhack
Environment: For arm64 build, from x86_64 machine
Branch: master

Description:

Unable to cross compile openwrt with node language package successfully, building image with make V=sc yields the error below at the end:

  g++  -o /mnt/vmStore/openwrt/build_dir/target-aarch64_cortex-a53_musl/node-v16.19.1/out/Release/obj.host/icutools/deps/icu-small/source/tools/toolutil/pkg_genc.o ../deps/icu-small/source/tools/toolutil/pkg_genc.cpp '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DICU_NO_USER_DATA_OVERRIDE' '-D__STDC_FORMAT_MACROS' '-DU_COMMON_IMPLEMENTATION=1' '-DU_I18N_IMPLEMENTATION=1' '-DU_IO_IMPLEMENTATION=1' '-DU_TOOLUTIL_IMPLEMENTATION=1' '-DU_ATTRIBUTE_DEPRECATED=' '-D_CRT_SECURE_NO_DEPRECATE=' '-DU_STATIC_IMPLEMENTATION=1' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/icu-small/source/common -I../deps/icu-small/source/i18n -I../deps/icu-small/source/tools/toolutil  -msign-return-address=all -pthread -Wall -Wextra -Wno-unused-parameter -Wno-deprecated-declarations -Wno-strict-aliasing -O3 -fno-omit-frame-pointer -fno-exceptions -std=gnu++14 -frtti -MMD -MF /mnt/vmStore/openwrt/build_dir/target-aarch64_cortex-a53_musl/node-v16.19.1/out/Release/.deps//mnt/vmStore/openwrt/build_dir/target-aarch64_cortex-a53_musl/node-v16.19.1/out/Release/obj.host/icutools/deps/icu-small/source/tools/toolutil/pkg_genc.o.d.raw   -c
g++: error: unrecognized command line option '-msign-return-address=all'

Is there a patch I can use for now?

@nxhack
Copy link
Contributor

nxhack commented Feb 22, 2023

(I am planning to support openssl v3.x, but)

This issue is addressed in this patch.
/~https://github.com/openwrt/packages/blob/master/lang/node/patches/999-revert_enable_pointer_authentication_on_arm64.patch

See also discussion in Upstream.
nodejs/node#45756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants