From f299d802f859e1cbdc10fea9f334b17f7f51f7b8 Mon Sep 17 00:00:00 2001 From: Hailong Cui Date: Wed, 18 Sep 2024 14:29:40 +0800 Subject: [PATCH 1/2] remove nav group for dev tools Signed-off-by: Hailong Cui --- src/plugins/dev_tools/public/dev_tools_icon.test.tsx | 4 ---- src/plugins/dev_tools/public/dev_tools_icon.tsx | 5 ----- 2 files changed, 9 deletions(-) diff --git a/src/plugins/dev_tools/public/dev_tools_icon.test.tsx b/src/plugins/dev_tools/public/dev_tools_icon.test.tsx index 47d9a621600f..ec31aad03a55 100644 --- a/src/plugins/dev_tools/public/dev_tools_icon.test.tsx +++ b/src/plugins/dev_tools/public/dev_tools_icon.test.tsx @@ -7,7 +7,6 @@ import React from 'react'; import { fireEvent, render } from '@testing-library/react'; import { DevToolsIcon } from './dev_tools_icon'; import { coreMock } from '../../../core/public/mocks'; -import { DEFAULT_NAV_GROUPS } from '../../../core/public'; describe('', () => { it('should call chrome.navGroup.setCurrentNavGroup and application.navigateToApp methods from core service when click', () => { @@ -15,9 +14,6 @@ describe('', () => { const { container } = render(); const component = container.children[0]; fireEvent.click(component); - expect(coreStartMock.chrome.navGroup.setCurrentNavGroup).toBeCalledWith( - DEFAULT_NAV_GROUPS.dataAdministration.id - ); expect(coreStartMock.application.navigateToApp).toBeCalledWith('foo'); }); }); diff --git a/src/plugins/dev_tools/public/dev_tools_icon.tsx b/src/plugins/dev_tools/public/dev_tools_icon.tsx index b58ef03473a6..f7f63ec1114e 100644 --- a/src/plugins/dev_tools/public/dev_tools_icon.tsx +++ b/src/plugins/dev_tools/public/dev_tools_icon.tsx @@ -6,7 +6,6 @@ import React from 'react'; import { EuiButtonIcon } from '@elastic/eui'; import { CoreStart } from 'opensearch-dashboards/public'; -import { DEFAULT_NAV_GROUPS } from '../../../core/public'; export function DevToolsIcon({ core, appId }: { core: CoreStart; appId: string }) { return ( @@ -14,10 +13,6 @@ export function DevToolsIcon({ core, appId }: { core: CoreStart; appId: string } aria-label="go-to-dev-tools" iconType="consoleApp" onClick={() => { - /** - * This is a workaround in 2.16, once devTools being refactor to a drawer, we can remove the setCurrentNavGroup line. - */ - core.chrome.navGroup.setCurrentNavGroup(DEFAULT_NAV_GROUPS.dataAdministration.id); core.application.navigateToApp(appId); }} /> From 16d5787ac16cc334d6262985db0bf155072126fa Mon Sep 17 00:00:00 2001 From: "opensearch-changeset-bot[bot]" <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Date: Wed, 18 Sep 2024 06:32:45 +0000 Subject: [PATCH 2/2] Changeset file for PR #8218 created/updated --- changelogs/fragments/8218.yml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelogs/fragments/8218.yml diff --git a/changelogs/fragments/8218.yml b/changelogs/fragments/8218.yml new file mode 100644 index 000000000000..516c0850caf3 --- /dev/null +++ b/changelogs/fragments/8218.yml @@ -0,0 +1,2 @@ +fix: +- Remove nav group for dev tools ([#8218](/~https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8218)) \ No newline at end of file