Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate Different Node.js Versions (14, 16, 18) in Test Suite #4129

Open
ananzh opened this issue May 24, 2023 · 0 comments
Open

Accommodate Different Node.js Versions (14, 16, 18) in Test Suite #4129

ananzh opened this issue May 24, 2023 · 0 comments
Labels
NODE 18 ⚙ technical debt If not paid, jeapardizes long-term success and maintainability of the repository. test:unit

Comments

@ananzh
Copy link
Member

ananzh commented May 24, 2023

Description
As we're now allowing users to run our application on Node.js versions 14, 16, and 18 (#4071), we have found that we need to make certain modifications to our tests for compatibility reasons. For example,

// ToDo: Remove this logic when Node 14 support is removed
const isNode14 = process.version.startsWith('v14.');

While this temporary solution works for now, we would like to open this issue to remind us removing and cleanup these tests. Pls search ToDo: Remove this logic when Node 14 support is removed to find all the three tests:

  • packages/osd-config-schema/src/errors/schema_error.test.ts
  • src/core/server/http/router/validator/validator.test.ts
  • src/plugins/visualizations/server/saved_objects/visualization_migrations.test.ts
@joshuarrrr joshuarrrr added technical debt If not paid, jeapardizes long-term success and maintainability of the repository. test:unit and removed untriaged labels May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NODE 18 ⚙ technical debt If not paid, jeapardizes long-term success and maintainability of the repository. test:unit
Projects
None yet
Development

No branches or pull requests

2 participants