Missing channels since last update #2831

clinique · 2022-03-11T15:25:34Z

I'm on milestone 3.3.0 Build 2797, updated this morning.
Many channels have disappeared from things.
Here's an example for Telegram Bot :

Many bindings seems impacted (openuv, telegram, logreader, astro...) and the log is full of this error :

2022-03-11 14:28:04.392 [WARN ] [ig.xml.osgi.XmlDocumentBundleTracker] - The XML document '/OH-INF/thing/channels.xml' in module 'org.openhab.binding.astro' could not be parsed: ChannelType 'itemType' must not be null or empty.
---- Debugging information ----
message             : ChannelType 'itemType' must not be null or empty.
class               : org.openhab.core.thing.xml.internal.ChannelTypeXmlResult
required-type       : org.openhab.core.thing.xml.internal.ChannelTypeXmlResult
converter-type      : org.openhab.core.thing.xml.internal.ChannelTypeConverter
path                : /thing-descriptions/channel-type[10]
line number         : 126
class[1]            : java.util.ArrayList
required-type[1]    : java.util.ArrayList
converter-type[1]   : com.thoughtworks.xstream.converters.collections.CollectionConverter
class[2]            : org.openhab.core.thing.xml.internal.ThingDescriptionList
required-type[2]    : org.openhab.core.thing.xml.internal.ThingDescriptionList
converter-type[2]   : org.openhab.core.thing.xml.internal.ThingDescriptionConverter
version             : 1.4.19
-------------------------------
com.thoughtworks.xstream.converters.ConversionException: ChannelType 'itemType' must not be null or empty.
---- Debugging information ----
message             : ChannelType 'itemType' must not be null or empty.
class               : org.openhab.core.thing.xml.internal.ChannelTypeXmlResult
required-type       : org.openhab.core.thing.xml.internal.ChannelTypeXmlResult
converter-type      : org.openhab.core.thing.xml.internal.ChannelTypeConverter
path                : /thing-descriptions/channel-type[10]
line number         : 126
class[1]            : java.util.ArrayList
required-type[1]    : java.util.ArrayList
converter-type[1]   : com.thoughtworks.xstream.converters.collections.CollectionConverter
class[2]            : org.openhab.core.thing.xml.internal.ThingDescriptionList
required-type[2]    : org.openhab.core.thing.xml.internal.ThingDescriptionList
converter-type[2]   : org.openhab.core.thing.xml.internal.ThingDescriptionConverter
version             : 1.4.19
-------------------------------
	at org.openhab.core.config.xml.util.GenericUnmarshaller.requireNonEmpty(GenericUnmarshaller.java:95) ~[?:?]
	at org.openhab.core.thing.xml.internal.ChannelTypeConverter.readItemType(ChannelTypeConverter.java:77) ~[?:?]
	at org.openhab.core.thing.xml.internal.ChannelTypeConverter.unmarshalType(ChannelTypeConverter.java:175) ~[?:?]
	at org.openhab.core.thing.xml.internal.ChannelTypeConverter.unmarshalType(ChannelTypeConverter.java:1) ~[?:?]
	at org.openhab.core.thing.xml.internal.AbstractDescriptionTypeConverter.unmarshal(AbstractDescriptionTypeConverter.java:193) ~[?:?]
	at com.thoughtworks.xstream.core.TreeUnmarshaller.convert(TreeUnmarshaller.java:74) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.core.AbstractReferenceUnmarshaller.convert(AbstractReferenceUnmarshaller.java:72) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:68) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:52) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.readBareItem(AbstractCollectionConverter.java:132) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.readItem(AbstractCollectionConverter.java:117) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.converters.collections.CollectionConverter.addCurrentElementToCollection(CollectionConverter.java:99) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.converters.collections.CollectionConverter.populateCollection(CollectionConverter.java:92) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.converters.collections.CollectionConverter.populateCollection(CollectionConverter.java:86) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.converters.collections.CollectionConverter.unmarshal(CollectionConverter.java:81) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.core.TreeUnmarshaller.convert(TreeUnmarshaller.java:74) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.core.AbstractReferenceUnmarshaller.convert(AbstractReferenceUnmarshaller.java:72) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:68) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:52) ~[bundleFile:1.4.19]
	at org.openhab.core.thing.xml.internal.ThingDescriptionConverter.unmarshal(ThingDescriptionConverter.java:56) ~[?:?]
	at com.thoughtworks.xstream.core.TreeUnmarshaller.convert(TreeUnmarshaller.java:74) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.core.AbstractReferenceUnmarshaller.convert(AbstractReferenceUnmarshaller.java:72) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:68) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:52) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.core.TreeUnmarshaller.start(TreeUnmarshaller.java:136) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.unmarshal(AbstractTreeMarshallingStrategy.java:32) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.XStream.unmarshal(XStream.java:1421) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.XStream.unmarshal(XStream.java:1399) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.XStream.fromXML(XStream.java:1350) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.XStream.fromXML(XStream.java:1304) ~[bundleFile:1.4.19]
	at org.openhab.core.config.xml.util.XmlDocumentReader.readFromXML(XmlDocumentReader.java:105) ~[bundleFile:?]
	at org.openhab.core.config.xml.osgi.XmlDocumentBundleTracker.parseDocuments(XmlDocumentBundleTracker.java:396) [bundleFile:?]
	at org.openhab.core.config.xml.osgi.XmlDocumentBundleTracker.processBundle(XmlDocumentBundleTracker.java:382) [bundleFile:?]
	at org.openhab.core.config.xml.osgi.XmlDocumentBundleTracker$2.run(XmlDocumentBundleTracker.java:347) [bundleFile:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) [?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
	at java.lang.Thread.run(Thread.java:829) [?:?]

I suspect a change in core.
Same behaviour observed in my dev environment on eclipse.

The text was updated successfully, but these errors were encountered:

clinique · 2022-03-11T17:35:49Z

Progressing in my search. This seems related to channel-types of kind trigger that has no item-type, witch seems normal.

clinique · 2022-03-11T17:47:15Z

Adding
<item-type>String</item-type>
to trigger channel-types I stopped having errors in log at start.

J-N-K · 2022-03-11T17:56:29Z

This error message was introduced in #2775.

clinique · 2022-03-11T18:31:09Z

Ok, but it is not only an error message, it prevents things from loading their channels.

J-N-K · 2022-03-11T18:36:26Z

Yes, but the newly introduced requireNonEmpty throws an exception if the element is empty. This prevents the channel from loading.

wborn · 2022-03-12T07:45:54Z

Yes it is probably caused by my PR. I'll have a look after some coffee. 😉

Trigger channel types failed to load because the item type became required with the changes in openhab#2775. Also adds a unit test for the ThingDescriptionReader to prevent future regressions. Fixes openhab#2831 Signed-off-by: Wouter Born <github@maindrain.net>

Trigger channel types failed to load because the item type became required with the changes in #2775. Also adds a unit test for the ThingDescriptionReader to prevent future regressions. Fixes #2831 Signed-off-by: Wouter Born <github@maindrain.net>

openhab-bot · 2022-03-12T22:39:09Z

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/trigger-channeltype-itemtype-must-not-be-null-or-empty/134163/3

Trigger channel types failed to load because the item type became required with the changes in openhab#2775. Also adds a unit test for the ThingDescriptionReader to prevent future regressions. Fixes openhab#2831 Signed-off-by: Wouter Born <github@maindrain.net> GitOrigin-RevId: 92a6c1c

J-N-K mentioned this issue Mar 11, 2022

Add more null annotations to XML processing classes #2775

Merged

wborn mentioned this issue Mar 12, 2022

Fix trigger channels not found #2833

Merged

kaikreuzer closed this as completed in #2833 Mar 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Missing channels since last update #2831

Missing channels since last update #2831

clinique commented Mar 11, 2022 •

edited

Loading

clinique commented Mar 11, 2022

clinique commented Mar 11, 2022 •

edited

Loading

J-N-K commented Mar 11, 2022

clinique commented Mar 11, 2022 •

edited

Loading

J-N-K commented Mar 11, 2022

wborn commented Mar 12, 2022

openhab-bot commented Mar 12, 2022

Missing channels since last update #2831

Missing channels since last update #2831

Comments

clinique commented Mar 11, 2022 • edited Loading

clinique commented Mar 11, 2022

clinique commented Mar 11, 2022 • edited Loading

J-N-K commented Mar 11, 2022

clinique commented Mar 11, 2022 • edited Loading

J-N-K commented Mar 11, 2022

wborn commented Mar 12, 2022

openhab-bot commented Mar 12, 2022

clinique commented Mar 11, 2022 •

edited

Loading

clinique commented Mar 11, 2022 •

edited

Loading

clinique commented Mar 11, 2022 •

edited

Loading