Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindings translation in French #11490

Closed
17 of 19 tasks
lolodomo opened this issue Nov 1, 2021 · 24 comments
Closed
17 of 19 tasks

Bindings translation in French #11490

lolodomo opened this issue Nov 1, 2021 · 24 comments

Comments

@lolodomo
Copy link
Contributor

lolodomo commented Nov 1, 2021

We have 60 bindings available for translation in Crowdin (first November of 2021).

We have in the addons repo 21 bindings with a French translation.

Here are the bindings still to be fixed, with a French translation in the addons repo but not available in Crowdin (no default properties file defined):

Here are the bindings requiring an optimization if the properties files:

Here are the partial (in progress) translations of bindings in Crowdin:

Here are the bindings requiring a change for discovery result:

@clinique for information and support

@lolodomo
Copy link
Contributor Author

lolodomo commented Nov 1, 2021

As a reminder: openhab/openhab-core#2544

@clinique
Copy link
Contributor

clinique commented Nov 1, 2021

I'll give you a help @lolodomo , please do not do anything on Netatmo current version. The one under PR has crowdin included, and I would prefer having to fight with file conflicts.

@lolodomo
Copy link
Contributor Author

lolodomo commented Nov 1, 2021

@clinique : I am going to create the default properties file for the vigicrues binding. There is nothing special to handle.

@lolodomo
Copy link
Contributor Author

lolodomo commented Nov 1, 2021

@clinique : while I was managing the vigicrues binding, I was very surprised to discover only 3 channels on my thing. I then tried with the last snapshot (2541) and that is the same thing.

image

I found this log entry: : Historical flooding data are not available H226000102 : null
Is your binding removing some of the channels ?
Edit: ok I see in the thing handler that some channels are removed, depending on conditions. Can you provide a station that will have all channels ?

@clinique
Copy link
Contributor

clinique commented Nov 1, 2021 via email

@clinique
Copy link
Contributor

clinique commented Nov 3, 2021

@lolodomo : for AirQuality, please note that there is currently a PR pending that incorporates crowdin compatibility.

@lolodomo
Copy link
Contributor Author

lolodomo commented Nov 5, 2021

@clinique : I think this is a little useless to start a translation when the default properties file is not full, like for example the lametrictime binding. First the default properties file must be updated.

@clinique
Copy link
Contributor

clinique commented Nov 5, 2021

@lolodomo : ok, clear.

@lolodomo
Copy link
Contributor Author

lolodomo commented Nov 9, 2021

@clinique : note that for openuv, few strings are still to be translated. For airquality, a change will be required to make the discovery label translatable.

@lolodomo
Copy link
Contributor Author

lolodomo commented Nov 9, 2021

@clinique: for the astro binding, did you start a translation from scratch in Crowdin ? Because we already have a file in Github, probably not full.

@clinique
Copy link
Contributor

@lolodomo : finished translations for OpenUV in crowdin. Astro : yes, I started it in Crowdin directly.

@lolodomo
Copy link
Contributor Author

Astro : yes, I started it in Crowdin directly.

If it was empty, it is not normal as the work was already done directly in girhub.
I will probably import the existing file from girhub inside Crowdin, hoping your proposals will not be erased in Crowdin so that I can then choose the best.

@lolodomo
Copy link
Contributor Author

Astro : yes, I started it in Crowdin directly.

If it was empty, it is not normal as the work was already done directly in girhub. I will probably import the existing file from girhub inside Crowdin, hoping your proposals will not be erased in Crowdin so that I can then choose the best.

The file in github is for tr not fr ! So there is no problem and you can continue in Crowdin. I am going to start approving your proposals.

@lolodomo
Copy link
Contributor Author

lolodomo commented Nov 11, 2021

@lolodomo : finished translations for OpenUV in crowdin. Astro : yes, I started it in Crowdin directly.

This is now in the current PR.

Edit: now merged

@clinique
Copy link
Contributor

@lolodomo : VolvoOnCall finished in Crowdin

@lolodomo
Copy link
Contributor Author

@lolodomo : VolvoOnCall finished in Crowdin

Thank you @clinique , the PR is now opened.

@lolodomo
Copy link
Contributor Author

Considering all your bindings @clinique, a French translation is now available except for your xmltv binding. Do you need my help to produce the default properties file ?
The netatmo binding is an exception due to your in progress refactoring.
The meteoalerte binding is another exception as French is directly provided as default !

On my side, I have the freebox binding with a missing French translation but we have your new binding freeboxos coming.
For me, remains some work still to do with the powermax and the remoteopenhab bindings.

@clinique
Copy link
Contributor

Xmltv binding translation is nearly ready and will be submitted soon

@lolodomo
Copy link
Contributor Author

I have a real difficulty with a proper translation of openHAB concepts like "thing" and "channel". Using "ce thing" or "cette chose" make no sense for me ;)
WDYT ?

@clinique
Copy link
Contributor

On my side, I think it's better to keep openHAB's wording - at least for Thing. Using 'Thing' in extenso. I think that channel can accept a translation to "canal", but then we would need a consistent approach everywhere - like you did with "Extension" in place of "Binding".

@mherwege
Copy link
Contributor

mherwege commented Dec 5, 2021

From my perspective, the Niko Home Control French translation is complete in Crowdin. But I am not a native French speaker. It needs to be reviewed and the translation needs to be accepted, which I cannot do. Niko is a Belgian product. I did the translation in Dutch as well, which is already available. Adding French makes a lot of sense.

@lolodomo
Copy link
Contributor Author

lolodomo commented Dec 5, 2021

From my perspective, the Niko Home Control French translation is complete in Crowdin. But I am not a native French speaker. It needs to be reviewed and the translation needs to be accepted, which I cannot do. Niko is a Belgian product. I did the translation in Dutch as well, which is already available. Adding French makes a lot of sense.

Yes, this is in my TODO list. When I took a look, I was not fully satisfied with the proposed translation ;)
This will be before the official 3.2 version is released.

@lolodomo
Copy link
Contributor Author

From my perspective, the Niko Home Control French translation is complete in Crowdin. But I am not a native French speaker. It needs to be reviewed and the translation needs to be accepted, which I cannot do. Niko is a Belgian product. I did the translation in Dutch as well, which is already available. Adding French makes a lot of sense.

Yes, this is in my TODO list. When I took a look, I was not fully satisfied with the proposed translation ;) This will be before the official 3.2 version is released.

This is now done.

@lolodomo
Copy link
Contributor Author

lolodomo commented May 7, 2022

I close this issue as my initial intention was to follow the migration of all existing French translations in Crowdin.
This is done now.
For the Netatmo binding, new translations have to be filled in Crowdin now that the binding was fully refactored.

@lolodomo lolodomo closed this as completed May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants