Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failing with go-digest@4ca13015b68d8b53802e6c9049953cdfc9a102ce #697

Closed
AkihiroSuda opened this issue Jun 13, 2017 · 4 comments
Closed

Comments

@AkihiroSuda
Copy link
Member

df6f3c5 fails with opencontainers/go-digest@4ca1301

(Sorry this seems my mistake)

--- FAIL: TestDescriptor (0.01s)
        descriptor_test.go:300: test 14: expected validation failure true but got false, err <nil>
FAIL
FAIL    github.com/opencontainers/image-spec/schema     0.045s

Test 14 is

// expected failure: digest does not match pattern (characters needs to be lower for sha256)
{
descriptor: `
{
"mediaType": "application/vnd.oci.image.manifest.v1+json",
"size": 7682,
"digest": "sha256:5B0BCABD1ED22E9FB1310CF6C2DEC7CDEF19F0AD69EFA1F392E94A4333501270"
}
`,

@AkihiroSuda
Copy link
Member Author

seems tracked in #696

@stevvooe
Copy link
Contributor

@AkihiroSuda Does that need to be fixed upstream in go-digest?

@AkihiroSuda
Copy link
Member Author

IIUC no, CI passing in #696

@wking
Copy link
Contributor

wking commented Jun 16, 2017

We can probably close this with #696 landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants