Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock S3 API in test/server/routes/images.test.js #6648

Open
Betree opened this issue Apr 7, 2023 · 5 comments · May be fixed by opencollective/opencollective-api#10688
Open

Mock S3 API in test/server/routes/images.test.js #6648

Betree opened this issue Apr 7, 2023 · 5 comments · May be fixed by opencollective/opencollective-api#10688
Labels
complexity → simple developer experience enhancement good first issue test

Comments

@Betree
Copy link
Member

Betree commented Apr 7, 2023

The test test/server/routes/images.test.js currently uses real (test) S3 credentials to test our upload endpoints.

This forces us to skip the tests on forks, adding unnecessary costs (both $$ and run time).

Using nock, we should update the test with the S3 calls & responses mocked.
@ashutosh887
Copy link

I would like to work on this issue

@Betree
Copy link
Member Author

Betree commented Jun 12, 2023

@ashutosh887 One at a time, please complete your already-assigned PRs and ask again once they're merged

@aguywithcode
Copy link

If this is still open, I'd like to investigate the issue.

@Betree
Copy link
Member Author

Betree commented Jul 27, 2023

It's all yours, feel free to ask if you have any questions!

@aguywithcode
Copy link

Stuck with setting up test environment. Filed a bug report #6912

@Betree Betree linked a pull request Feb 12, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity → simple developer experience enhancement good first issue test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(s3): Use minio in local + CI opencollective/opencollective-api
3 participants
@Betree @aguywithcode @ashutosh887