From bbc972df0201160118d3289322b03073f8bc6bb5 Mon Sep 17 00:00:00 2001 From: Cijo Thomas Date: Thu, 25 Jul 2024 22:49:44 -0700 Subject: [PATCH 1/4] Minor clarification on BatchExportingProcessor behavior --- specification/trace/sdk.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index 82bec706359..439809845c3 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -703,9 +703,9 @@ This is an implementation of the `SpanProcessor` which create batches of finishe spans and passes the export-friendly span data representations to the configured `SpanExporter`. -The processor SHOULD export a batch when any of the following happens AND -`SpanProcessor#Export()` has not yet returned (for additional concurrency -details see the [Export() specification](#exportbatch)): +The processor SHOULD export a batch when any of the following happens AND the +previous export operation has finished (for additional concurrency details see +the [Export() specification](#exportbatch)): - `scheduledDelayMillis` after the processor is constructed OR the first span is received by the span processor. From 0365f4be4995b26f46a25c5085977306ed65938a Mon Sep 17 00:00:00 2001 From: Cijo Thomas Date: Fri, 26 Jul 2024 07:24:48 -0700 Subject: [PATCH 2/4] Update specification/trace/sdk.md Co-authored-by: Tristan Sloughter --- specification/trace/sdk.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index 439809845c3..916aa57b1e2 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -704,7 +704,7 @@ spans and passes the export-friendly span data representations to the configured `SpanExporter`. The processor SHOULD export a batch when any of the following happens AND the -previous export operation has finished (for additional concurrency details see +previous export call has returned (for additional concurrency details see the [Export() specification](#exportbatch)): - `scheduledDelayMillis` after the processor is constructed OR the first span From f770ace8a66084fccc3ad932130b3e3aee9302fb Mon Sep 17 00:00:00 2001 From: Cijo Thomas Date: Tue, 30 Jul 2024 12:12:09 -0700 Subject: [PATCH 3/4] remove redundant wording --- specification/trace/sdk.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index 916aa57b1e2..57bceffa5c6 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -715,8 +715,6 @@ the [Export() specification](#exportbatch)): - The queue contains `maxExportBatchSize` or more spans. - `ForceFlush` is called. -If any of the above events occurs before `Export()` returns, the span processor -should wait until `Export()` returns before exporting the next batch. If the queue is empty when an export is triggered, the processor MAY export an empty batch OR skip the export and consider it to be completed immediately. From 7884498be666d7faef995c194562b3ec54030a13 Mon Sep 17 00:00:00 2001 From: Armin Ruech <7052238+arminru@users.noreply.github.com> Date: Mon, 19 Aug 2024 15:42:27 +0200 Subject: [PATCH 4/4] Add CHANGELOG --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b0e7987087d..2ef43e77f07 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,9 @@ release. ### Traces +- Minor clarification on BatchExportingProcessor behavior. + ([#4164](/~https://github.com/open-telemetry/opentelemetry-specification/pull/4164)) + ### Metrics ### Logs