From 33937d667f5989650bbd85680980a82db260c7bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Paj=C4=85k?= Date: Mon, 11 Jul 2022 20:04:00 +0200 Subject: [PATCH 1/6] Make Metrics SDK Configuration stable --- specification/sdk-environment-variables.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/sdk-environment-variables.md b/specification/sdk-environment-variables.md index e5925975b46..50d3498018b 100644 --- a/specification/sdk-environment-variables.md +++ b/specification/sdk-environment-variables.md @@ -237,7 +237,7 @@ Known values for `OTEL_LOGS_EXPORTER` are: ## Metrics SDK Configuration -**Status**: [Experimental](document-status.md) +**Status**: [Stable](document-status.md) | Name | Description | Default | Notes | |-----------------|---------|-------------|---------| From 2e32ca42d2eb0c735177bd2e6dbcf1ffe5be1a56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Paj=C4=85k?= Date: Thu, 14 Jul 2022 11:07:17 +0200 Subject: [PATCH 2/6] PR feedback --- specification/sdk-environment-variables.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/specification/sdk-environment-variables.md b/specification/sdk-environment-variables.md index 50d3498018b..a5b70344bba 100644 --- a/specification/sdk-environment-variables.md +++ b/specification/sdk-environment-variables.md @@ -237,7 +237,7 @@ Known values for `OTEL_LOGS_EXPORTER` are: ## Metrics SDK Configuration -**Status**: [Stable](document-status.md) +**Status**: [Mixed](../../document-status.md) | Name | Description | Default | Notes | |-----------------|---------|-------------|---------| @@ -251,6 +251,11 @@ Known values for `OTEL_METRICS_EXEMPLAR_FILTER` are: ### Periodic exporting MetricReader +**Status**: [Stable](document-status.md) + +Environment variables specific for the push metrics exporters (OTLP, stdout, in-memory) +that use [periodic exporting MetricReader](metrics/sdk.md#periodic-exporting-metricreader). + | Name | Description | Default | Notes | | ----------------------------- | ----------------------------------------------------------------------------- | ------- | ----- | | `OTEL_METRIC_EXPORT_INTERVAL` | The time interval (in milliseconds) between the start of two export attempts. | 60000 | | From d412829c6a95cc84b565ce5557754a7c420771ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Paj=C4=85k?= Date: Thu, 14 Jul 2022 11:11:06 +0200 Subject: [PATCH 3/6] Update changelog --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7752515b01b..e02aff41479 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,9 @@ release. - Clarify the return of `Export(batch)` in the Batch Span Processor and exporter concurrency ([#2452](/~https://github.com/open-telemetry/opentelemetry-specification/pull/2452)) - Clarify that Context should not be mutable when setting a span ([#2637](/~https://github.com/open-telemetry/opentelemetry-specification/pull/2637)) +- Mark `OTEL_METRIC_EXPORT_INTERVAL`, `OTEL_METRIC_EXPORT_TIMEOUT` + environment variables as stable + ([#2658](/~https://github.com/open-telemetry/opentelemetry-specification/pull/2658)) ### Metrics From a3d4d488246f3d6841d9476374892a6da96f50c9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Paj=C4=85k?= Date: Thu, 14 Jul 2022 11:44:12 +0200 Subject: [PATCH 4/6] Update compliance matrix --- spec-compliance-matrix.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/spec-compliance-matrix.md b/spec-compliance-matrix.md index 2af22a93ea8..9557197805e 100644 --- a/spec-compliance-matrix.md +++ b/spec-compliance-matrix.md @@ -288,6 +288,8 @@ Note: Support for environment variables is optional. |OTEL_TRACES_SAMPLER_ARG | + | + | | + | + | + | | - | - | - | | |OTEL_ATTRIBUTE_VALUE_LENGTH_LIMIT | + | - | | | + | - | | | | - | | |OTEL_ATTRIBUTE_COUNT_LIMIT | + | - | | | + | - | | | | - | | +|OTEL_METRIC_EXPORT_INTERVAL | - | + | | | | | + | | | - | | +|OTEL_METRIC_EXPORT_TIMEOUT | - | - | | | | | + | | | - | | |OTEL_METRICS_EXEMPLAR_FILTER | - | + | | | | | | | | - | | |OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE | - | + | | | | | | | | - | | From 54cd8a2c03ee8415470928806cd5d9057c64f1fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Paj=C4=85k?= Date: Thu, 14 Jul 2022 11:44:32 +0200 Subject: [PATCH 5/6] Fix link --- specification/sdk-environment-variables.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/sdk-environment-variables.md b/specification/sdk-environment-variables.md index a5b70344bba..7820caf07b0 100644 --- a/specification/sdk-environment-variables.md +++ b/specification/sdk-environment-variables.md @@ -237,7 +237,7 @@ Known values for `OTEL_LOGS_EXPORTER` are: ## Metrics SDK Configuration -**Status**: [Mixed](../../document-status.md) +**Status**: [Mixed](document-status.md) | Name | Description | Default | Notes | |-----------------|---------|-------------|---------| From d6f0144590750bf3edead6e56c0b98c8f9e890c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Paj=C4=85k?= Date: Thu, 14 Jul 2022 11:48:02 +0200 Subject: [PATCH 6/6] Fix changelog --- CHANGELOG.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e02aff41479..d9fb90203cf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,9 +14,6 @@ release. - Clarify the return of `Export(batch)` in the Batch Span Processor and exporter concurrency ([#2452](/~https://github.com/open-telemetry/opentelemetry-specification/pull/2452)) - Clarify that Context should not be mutable when setting a span ([#2637](/~https://github.com/open-telemetry/opentelemetry-specification/pull/2637)) -- Mark `OTEL_METRIC_EXPORT_INTERVAL`, `OTEL_METRIC_EXPORT_TIMEOUT` - environment variables as stable - ([#2658](/~https://github.com/open-telemetry/opentelemetry-specification/pull/2658)) ### Metrics @@ -57,6 +54,10 @@ release. ### SDK Configuration +- Mark `OTEL_METRIC_EXPORT_INTERVAL`, `OTEL_METRIC_EXPORT_TIMEOUT` + environment variables as Stable + ([#2658](/~https://github.com/open-telemetry/opentelemetry-specification/pull/2658)) + ### Telemetry Schemas ### Common