-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should span Status description be of low cardinality? #3687
Comments
You mention the span name, but you mean the description inside the span status, right? |
Yes sorry, I've fixed the first link, it is all about the description of the span status |
there's been a bit of prior discussion on this, see #3496 I have the feeling that we may need to relax the restriction on span status description based on feedback from @Oberon00 and @jsuereth
check out the brand new |
@trask I agree we should relax the restriction on span status -- and that some other well-specified attribute value should be used when metrics are requested. |
is this still being discussed? |
I think a PR would be useful to clarify that span status description does not need to be low cardinality, since this has been unclear previously. |
Currently the spec about span status mentions that
the Description SHOULD be documented and predictable.
andDescription that provides a descriptive message of the Status
.We are using a library which adds to the description something like "failed to connect to queue 'uuid'" where 'uuid' is the whole uuid. This creates many unique descriptions which would prevent us from using description as a metric label, something that is on the other hand desirable in http spans.
Should the spec add a note
description SHOULD be of low cardinality
ordescription cardinality should follow the guidance for span names
?The text was updated successfully, but these errors were encountered: