-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdk/__init__.py not correctly packaged #1078
Comments
Sorry, I remembered something about a way to include files in the package but it was for additional files, as explained here. |
For context: I encountered this issue while testing PR #1069. The tests pass when running Tox installs the package without the |
Looks like this line is the issue:
The reason it fails Line 241 in 65ddc2d
|
Strangely, it also looks like the python3 -m venv venv
source venv/bin/activate
pip install opentelemetry-api opentelemetry-sdk
tree -I *.pyc -I __pycache__ venv/lib/python3.8/site-packages/opentelemetry
venv/lib/python3.8/site-packages/opentelemetry
├── configuration │ ├── __init__.py
│ └── py.typed ├── context
│ ├── aiocontextvarsfix.py │ ├── context.py
│ ├── contextvars_context.py
│ ├── __init__.py
│ ├── py.typed
│ └── threadlocal_context.py
├── correlationcontext
│ ├── __init__.py
│ └── propagation
│ └── __init__.py
├── distributedcontext
│ └── py.typed
├── metrics
│ ├── __init__.py
│ └── py.typed
├── propagators
│ ├── composite.py
│ └── __init__.py
├── sdk
│ ├── metrics
│ │ ├── export
│ │ │ ├── aggregate.py
│ │ │ ├── batcher.py
│ │ │ ├── controller.py
│ │ │ ├── __init__.py │ │ │ └── in_memory_metrics_exporter.py
│ │ ├── __init__.py
│ │ └── view.py
│ ├── resources
│ │ └── __init__.py
│ ├── trace
│ │ ├── export
│ │ │ ├── __init__.py
│ │ │ └── in_memory_span_exporter.py
│ │ ├── __init__.py
│ │ └── propagation
│ │ ├── b3_format.py
│ │ └── __init__.py
│ └── util
│ ├── __init__.py
│ └── instrumentation.py
├── trace
│ ├── __init__.py
│ ├── propagation
│ │ ├── httptextformat.py
│ │ ├── __init__.py
│ │ └── tracecontexthttptextformat.py
│ ├── py.typed
│ ├── sampling.py
│ ├── span.py
│ └── status.py
└── util
├── __init__.py
├── py.typed
└── types.py
18 directories, 41 files Is this by design? It is included in the package resources so this still works: >>> import pkg_resources
>>> pkg_resources.get_distribution("opentelemetry-sdk").version
'0.12b0' |
…y#1078) Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Describe your environment
macOS-10.15.5
Python 3.8
opentelemetry-sdk==0.12b0
Steps to reproduce
What is the expected behavior?
I expected the
__init__.py
fromopentelemetry-sdk/src/opentelemetry/sdk/__init__.py
in the repository to be present.What is the actual behavior?
The file was not there.
The text was updated successfully, but these errors were encountered: