Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-<key> sends scancode not keycode #522

Closed
ntgraff opened this issue Jul 31, 2019 · 6 comments
Closed

control-<key> sends scancode not keycode #522

ntgraff opened this issue Jul 31, 2019 · 6 comments
Labels
A-input Area: Input management, keyboard layout, IME etc. bug Something isn't working I-daily-editor-blocker An issue blocking use of the editor as a day-to-day editor

Comments

@ntgraff
Copy link

ntgraff commented Jul 31, 2019

I use a non-qwerty keyboard layout, and when not pressing control the keys send as expected, but when control is pressed it sends the scancode, not the keycode. For example if I press <c-p> it will send <c-r> when using dvorak.

@CrossR CrossR added the enhancement New feature or request label Jul 31, 2019
@bryphe bryphe added the A-input Area: Input management, keyboard layout, IME etc. label Aug 6, 2019
bryphe added a commit that referenced this issue Aug 13, 2019
* Initial fix for #522 - delegate work to thread

* Update lockfiles

* Formatting

* Start wiring up an amortized menu filter method

* Hook up amortized job to 'TICK' action

* Formatting

* Job factoring

* Some tweaks for the menu

* Fix bug in menu job were we only processing a single item!

* Pass query to ripgrep

* Updates

* Tweak constants

* Turn down constants

* Remove esy and node_modules folder

* Globs

* Don't leak file descriptors

* Fix logging

* Use map instead of mapw

* Formatting

* Update integration test

* Fix integration test on Mac

* Get integration test passing

* Get test building / running

* Fix test to actually increment counter

* Remove print_endline

* Pin rench

* Update lockfiles

* Formatting

* Fix up selected item behavior

* Formatting

* Use home directory on Mac

* Formatting

* Try remove the pipe-close for Windows

* Update lockfiles

* Pin camomile

* Update lockfiles

* Use master rench

* Turn down length of QuickOpenFileDescriptor test

* Formatting

* Bump down number again
benox3 pushed a commit to benox3/oni2 that referenced this issue Aug 27, 2019
…nivim#563)

* Initial fix for onivim#522 - delegate work to thread

* Update lockfiles

* Formatting

* Start wiring up an amortized menu filter method

* Hook up amortized job to 'TICK' action

* Formatting

* Job factoring

* Some tweaks for the menu

* Fix bug in menu job were we only processing a single item!

* Pass query to ripgrep

* Updates

* Tweak constants

* Turn down constants

* Remove esy and node_modules folder

* Globs

* Don't leak file descriptors

* Fix logging

* Use map instead of mapw

* Formatting

* Update integration test

* Fix integration test on Mac

* Get integration test passing

* Get test building / running

* Fix test to actually increment counter

* Remove print_endline

* Pin rench

* Update lockfiles

* Formatting

* Fix up selected item behavior

* Formatting

* Use home directory on Mac

* Formatting

* Try remove the pipe-close for Windows

* Update lockfiles

* Pin camomile

* Update lockfiles

* Use master rench

* Turn down length of QuickOpenFileDescriptor test

* Formatting

* Bump down number again
@ntgraff
Copy link
Author

ntgraff commented Aug 29, 2019

If I could get a pointer to where the code to fix this is I could try to work on it. This is blocking any use of the editor for me, as any key with control is broken. I would also petition to change the tag from enhancement to bug and/or daily editor blocker, because that is what it is.

@CrossR CrossR added bug Something isn't working I-daily-editor-blocker An issue blocking use of the editor as a day-to-day editor and removed enhancement New feature or request labels Aug 29, 2019
@CrossR
Copy link
Member

CrossR commented Aug 29, 2019

There is some input changes going on in the background around SDL to my knowledge, which may help in this area. There is talks over in discord about that.

@jcorbin
Copy link

jcorbin commented Sep 12, 2019

Related to #520 and #557

@bryphe
Copy link
Member

bryphe commented Oct 18, 2019

Hi @jcorbin and @ntgraff ,

This should be fixed in the latest builds - we now use SDL2 and pick up virtual key codes. I've tested Dvorak on Windows, OSX, and Arch Linux, and it seems to work as expected.

Would you be up for trying the latest and let me know if to works for you?

If not - let me know which platform you're using and I'll continue to investigate 👍

@ntgraff
Copy link
Author

ntgraff commented Oct 18, 2019

Seems to work as expected!

@ntgraff ntgraff closed this as completed Oct 18, 2019
@bryphe
Copy link
Member

bryphe commented Oct 18, 2019

Great news! Thanks for checking, @ntgraff !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-input Area: Input management, keyboard layout, IME etc. bug Something isn't working I-daily-editor-blocker An issue blocking use of the editor as a day-to-day editor
Projects
None yet
Development

No branches or pull requests

4 participants