From 762aed05cb0ba3b584982026d028bb5659d3fd8b Mon Sep 17 00:00:00 2001 From: wolfy1339 Date: Wed, 5 Feb 2025 15:43:12 -0500 Subject: [PATCH] fix(types): mark type parameters as optional Some types which end-users could be using, declare the type parameters as requried, when in fact they are entirely optional. This arises when users try to use the event handler code on it's own --- src/event-handler/index.ts | 4 ++-- src/types.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/event-handler/index.ts b/src/event-handler/index.ts index c6e236a5..847c663f 100644 --- a/src/event-handler/index.ts +++ b/src/event-handler/index.ts @@ -16,7 +16,7 @@ import { import { receiverHandle as receive } from "./receive.js"; import { removeListener } from "./remove-listener.js"; -export interface EventHandler { +export interface EventHandler { on( event: E | E[], callback: HandlerFunction, @@ -38,7 +38,7 @@ export interface EventHandler { receive(event: EmitterWebhookEvent | WebhookError): Promise; } -export function createEventHandler( +export function createEventHandler( options: Options, ): EventHandler { const state: State = { diff --git a/src/types.ts b/src/types.ts index b12e4311..b34ffa22 100644 --- a/src/types.ts +++ b/src/types.ts @@ -47,12 +47,12 @@ type TransformMethod = (event: EmitterWebhookEvent) => T | PromiseLike; export type HandlerFunction< TName extends EmitterWebhookEventName, - TTransformed, + TTransformed = unknown, > = (event: EmitterWebhookEvent & TTransformed) => any; export type RemoveHandlerFunction< TName extends EmitterWebhookEventName | "*", - TTransformed, + TTransformed = unknown, > = (event: EmitterWebhookEvent> & TTransformed) => any; type Hooks = {