Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

Investigate what sampler_type means and why this is unknown during check-traces tests #4

Closed
helio-frota opened this issue Dec 7, 2022 · 4 comments
Assignees

Comments

@helio-frota
Copy link
Member

This is the current result we have when running the CI tests on check-traces repository:

jaeger_traces_saved_by_svc_total{debug="false",result="ok",sampler_type="unknown",svc="check-traces"} 1
@helio-frota helio-frota self-assigned this Dec 7, 2022
@helio-frota helio-frota added this to SASI Dec 8, 2022
@helio-frota helio-frota moved this to Todo in SASI Dec 8, 2022
@pnaik1
Copy link
Member

pnaik1 commented Dec 13, 2022

jaegertracing/jaeger#2197 I think , this may be a help

@helio-frota
Copy link
Member Author

@pnaik1 that helps a lot thanks.

After read that issue you shared, I could bet that the otel js modules we are using have nothing to do with that unknown value. [ ? ] (very specific to Jaeger seems like we need that sampling-strategies.json)

Let's keep this issue open then.
We can take a look later at some point in 2023 👍

@helio-frota
Copy link
Member Author

helio-frota commented Jan 12, 2023

We can take a look later at some point in 2023

Taking a look in 2023 👍

In distributed tracing, sampling is frequently used to reduce the number of traces 
that are collected and stored in the backend. 
This is often desirable because it is easy to produce more data than can be 
efficiently stored and queried. 
Sampling allows us to store only a subset of the total traces produced.

https://medium.com/jaegertracing/adaptive-sampling-in-jaeger-50f336f4334#:~:text=Sampling%20allows%20us%20to%20store,source%20by%20the%20Jaeger%20project.

We don't need to worry about that for this repository.

Either way I found this comment: open-telemetry/opentelemetry-js#693 (comment)

UPDATE: This is not the correct reason to close this issue.
We are going to remain this closed as we are not going to focus on this.

But related to the link of the comment I shared, apparently the code has changed over time...
I added the code bellow in the example and ran locally and the result continues the same.
/~https://github.com/open-telemetry/opentelemetry-js/blob/ef6fcdcd1a7e5234758e3bcc9ff6c29db5ff4d23/packages/opentelemetry-sdk-trace-base/README.md#built-in-samplers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants