Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: Replacing an struct/enum/union with a trait or function (or vice versa) should not trigger "item missing" lints #313

Open
7 tasks
obi1kenobi opened this issue Jan 21, 2023 · 0 comments
Labels
A-lint Area: new or existing lint C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@obi1kenobi
Copy link
Owner

If an item importable by some path (say, a struct) is replaced by another kind of item (say, a trait) importable under the same path, this should not be reported as the original item being missing — this will unnecessarily confuse users, and the replacement isn't even necessarily a breaking change (e.g. see #297).

The resolution of #297 (via #306, #308, and #312) resolves the cases where a struct is converted into an enum or union (whenever unions in general are implemented). This resolves the most immediately painful aspect, but is not a full resolution.

Remaining tasks:

@obi1kenobi obi1kenobi added A-lint Area: new or existing lint C-enhancement Category: raise the bar on expectations labels Jan 21, 2023
@obi1kenobi obi1kenobi added E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. labels Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lint Area: new or existing lint C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Development

No branches or pull requests

1 participant