-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-post script is broken #6020
Comments
@RafaelGSS the actual error is "Some error occurred here! Error: Could not find changelog body of 21.0.0 release" |
Yes, I'm looking to it now. Looks like a "Notable Changes" section is desirable. |
Right, it's a "mandatory section" afaik |
It shouldn't. As well as the "commit" section. It doesn't fit semver-major commits. Anyway, I have a fix locally to upload the blog post, I'll open a PR soon. |
Are you sure about that? The old commit also required them, no? |
Not for semver-major releases. |
Let me double-check the original code. Because I can definitely see a rejection there on the original code. |
Right, I think I see the issue. Pushing a hot-fix. Would you mind waiting a little bit? |
#6022 I have the blog post ready. No need to rush. |
It's not about rushing, but about validating that the updated script works. Anyhow, I've pushed a hotfix. |
Confirmed the hotfix works. |
cc: @ovflowd
For now, I'll checkout a prior commit to make it work.
The text was updated successfully, but these errors were encountered: