Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-post script is broken #6020

Closed
RafaelGSS opened this issue Oct 17, 2023 · 11 comments
Closed

release-post script is broken #6020

RafaelGSS opened this issue Oct 17, 2023 · 11 comments

Comments

@RafaelGSS
Copy link
Member

➜  nodejs.org git:(v21-release) ✗ node ./scripts/release-post/index.mjs 21.0.0
Some error occurred here! TypeError: Cannot read properties of null (reading 'length')
    at file:///Users/rafaelgss/repos/os/nodejs.org/scripts/release-post/index.mjs:153:15
    at new Promise (<anonymous>)
    at file:///Users/rafaelgss/repos/os/nodejs.org/scripts/release-post/index.mjs:152:12
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Promise.all (index 0)

cc: @ovflowd

For now, I'll checkout a prior commit to make it work.

@ovflowd
Copy link
Member

ovflowd commented Oct 17, 2023

@RafaelGSS the actual error is "Some error occurred here! Error: Could not find changelog body of 21.0.0 release"

@RafaelGSS
Copy link
Member Author

Yes, I'm looking to it now. Looks like a "Notable Changes" section is desirable.

@ovflowd
Copy link
Member

ovflowd commented Oct 17, 2023

Right, it's a "mandatory section" afaik

@RafaelGSS
Copy link
Member Author

It shouldn't. As well as the "commit" section. It doesn't fit semver-major commits. Anyway, I have a fix locally to upload the blog post, I'll open a PR soon.

@ovflowd
Copy link
Member

ovflowd commented Oct 17, 2023

It shouldn't. As well as the "commit" section. It doesn't fit semver-major commits. Anyway, I have a fix locally to upload the blog post, I'll open a PR soon.

Are you sure about that? The old commit also required them, no?

@RafaelGSS
Copy link
Member Author

Not for semver-major releases.

@ovflowd
Copy link
Member

ovflowd commented Oct 17, 2023

Not for semver-major releases.

Let me double-check the original code. Because I can definitely see a rejection there on the original code.

@ovflowd
Copy link
Member

ovflowd commented Oct 17, 2023

Right, I think I see the issue. Pushing a hot-fix. Would you mind waiting a little bit?

@RafaelGSS
Copy link
Member Author

RafaelGSS commented Oct 17, 2023

#6022 I have the blog post ready. No need to rush.

@ovflowd
Copy link
Member

ovflowd commented Oct 17, 2023

#6022 I have the blog post ready. No need to rush.

It's not about rushing, but about validating that the updated script works. Anyhow, I've pushed a hotfix.

@RafaelGSS
Copy link
Member Author

Confirmed the hotfix works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants