Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated comparison details for WeakSet and WeakMap #56640

Open
BridgeAR opened this issue Jan 17, 2025 · 2 comments · May be fixed by #56648
Open

Outdated comparison details for WeakSet and WeakMap #56640

BridgeAR opened this issue Jan 17, 2025 · 2 comments · May be fixed by #56648
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@BridgeAR
Copy link
Member

Affected URL(s)

https://nodejs.org/api/assert.html#assertdeepstrictequalactual-expected-message

Description of the problem

The behavior for comparing WeakSets and WeakMaps was recently changed.

The documentation was also updated, while a few spots were missed. We need an update in the comparison details and in the example here: https://nodejs.org/api/assert.html#comparison-details_1
@BridgeAR BridgeAR added doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. labels Jan 17, 2025
@ishon19
Copy link

ishon19 commented Jan 17, 2025

Hi @BridgeAR, I would love to work on this one!

@BridgeAR
Copy link
Member Author

@ishon19 please feel free to open a PR to address this

@ishon19 ishon19 linked a pull request Jan 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: WeakSet and WeakMap comparison details ishon19/node
2 participants
@ishon19 @BridgeAR