From a9c04eaa279bb39f3bfe57a63dc4f43d8acf5bb4 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Wed, 24 Jul 2024 12:00:07 +0200 Subject: [PATCH] build: ensure v8_pointer_compression_sandbox is enabled on 64bit PR-URL: /~https://github.com/nodejs/node/pull/53884 Reviewed-By: Joyee Cheung Reviewed-By: Antoine du Hamel Reviewed-By: James M Snell Reviewed-By: Rafael Gonzaga --- common.gypi | 1 + configure.py | 1 + 2 files changed, 2 insertions(+) diff --git a/common.gypi b/common.gypi index af4e8fc1f2815b..7c0b4a0851b295 100644 --- a/common.gypi +++ b/common.gypi @@ -115,6 +115,7 @@ ['target_arch in "arm ia32 mips mipsel ppc"', { 'v8_enable_pointer_compression': 0, 'v8_enable_31bit_smis_on_64bit_arch': 0, + 'v8_enable_sandbox': 0 }], ['target_arch in "ppc64 s390x"', { 'v8_enable_backtrace': 1, diff --git a/configure.py b/configure.py index 10d0fbb83e611e..3084cc964cbe6d 100755 --- a/configure.py +++ b/configure.py @@ -1572,6 +1572,7 @@ def configure_v8(o): o['variables']['v8_use_siphash'] = 0 if options.without_siphash else 1 o['variables']['v8_enable_maglev'] = 1 if options.v8_enable_maglev else 0 o['variables']['v8_enable_pointer_compression'] = 1 if options.enable_pointer_compression else 0 + o['variables']['v8_enable_sandbox'] = 1 if options.enable_pointer_compression else 0 o['variables']['v8_enable_31bit_smis_on_64bit_arch'] = 1 if options.enable_pointer_compression else 0 o['variables']['v8_enable_shared_ro_heap'] = 0 if options.enable_pointer_compression or options.disable_shared_ro_heap else 1 o['variables']['v8_enable_extensible_ro_snapshot'] = 0