Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document napi_get_property_names() #307

Closed
gabrielschulhof opened this issue Apr 28, 2018 · 0 comments
Closed

Document napi_get_property_names() #307

gabrielschulhof opened this issue Apr 28, 2018 · 0 comments
Assignees
@gabrielschulhof

Comments

@gabrielschulhof
Copy link
Collaborator

The documentation for napi_get_property_names() does not say whether it
gets only enumerable properties or all properties, and does not say if it
includes symbols or not.

Re: nodejs/node#14256
@gabrielschulhof gabrielschulhof self-assigned this Apr 30, 2018
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Apr 30, 2018
n-api: refine napi_get_property_names() doc
e5395a9 
Document that only enumerable, string-keyed properties are returned.

Fixes: nodejs/abi-stable-node#307
@gabrielschulhof gabrielschulhof mentioned this issue Apr 30, 2018
Closed
3 tasks
MylesBorins pushed a commit to nodejs/node that referenced this issue May 4, 2018
@MylesBorins
doc: refine napi_get_property_names() doc
d7557e1 
Document that only enumerable, string-keyed properties are returned.

Fixes: nodejs/abi-stable-node#307
PR-URL: #20427
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrielschulhof gabrielschulhof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

n-api: refine napi_get_property_names() doc gabrielschulhof/node
1 participant
@gabrielschulhof