Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hope to add Chinese Font. #11640

Closed
chiyi4488 opened this issue Oct 5, 2018 · 24 comments
Closed

hope to add Chinese Font. #11640

chiyi4488 opened this issue Oct 5, 2018 · 24 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement

Comments

@chiyi4488
Copy link
Contributor

chiyi4488 commented Oct 5, 2018

At present, the English font of nextcloud can be felt to have another design to match the beauty. But with us in Chinese, our fonts are very aesthetic (not usable, it is ugly).

I suggest to add Noto Sans TC (Chinese Traditional) font
This font perfectly fits the aesthetics of Chinese and English. Perhaps you can directly replace the original nextcloud fonts with this one.

I think this font should be copyright-free (http://fonts.gstatic.com/ea/notosanstc/v1/OFL.txt)
If there are copyright issues, I am very willing to look for other fonts again.

This is the font URL
https://fonts.google.com/specimen/Noto+Sans+TC
Https://www.google.com/get/noto/help/cjk/
Https://www.google.com/get/noto/

Also, please add this message to your considerations.

Traditional Chinese (Taiwan, Hong Kong) is different from Simplified Chinese (China)
So you need to distinguish the fonts.

This will make nextcloud more and more perfect. I know this is very difficult. After all, each language has different fonts. I hope to use Chinese as a first step to slowly perfect each language.

Sincere hope can take my opinion, thank you.

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #10725 (Add AppLogger), #363 (Add Snap Information), #9320 (Add revision number), #10967 (Add fix response), and #11084 (Add QBMapper::insertOrUpdate()).

@MorrisJobke
Copy link
Member

Seems similar to #11299 - maybe we need to add more. @chiyi4488 Do you by any chance know if this is included in Open Sans somehow and what are the terms to check for?

cc @jancborchardt because we looked into this last week.

@chiyi4488
Copy link
Contributor Author

  1. Original or Modified Versions of the Font Software may be bundled,
    redistributed and/or sold with any software, provided that each copy
    contains the above copyright notice and this license. These can be
    included either as stand-alone text files, human-readable headers or
    in the appropriate machine-readable metadata fields within text or
    binary files as long as those fields can be easily viewed by the user.

http://fonts.gstatic.com/ea/notosanstc/v1/OFL.txt

I think this should not be in the open sans website, but I think this font should be free to use on the website.

@chiyi4488
Copy link
Contributor Author

chiyi4488 commented Oct 10, 2018

In addition, the Roboto font does not seem to support Chinese. Please note this.
Please see the picture

5

@jancborchardt
Copy link
Member

Note that we switched the main typeface to Nunito: https://fonts.google.com/specimen/Nunito. Noto is a good fallback, but maybe there’s even a rounded typeface supporting other character sets?

@chiyi4488
Copy link
Contributor Author

chiyi4488 commented Oct 27, 2018

What does it mean,it can support Chinese?

@chiyi4488
Copy link
Contributor Author

If there is no way to support Chinese, the displayed font will not change. (if the user is Chinese)

I think modifying the font is a good start, but it is recommended to set a multi-point font to support various languages.

@chiyi4488
Copy link
Contributor Author

I have an idea. When you update to the Nunito font, you can also add Noto Sans TC to Nunito. This will not affect the fonts you decide to add, also the Chinese font.
This is my own blog, most of which is written in Chinese, but I want to let you see how Noto Sans TC is displayed on the webpage (all Chinese are Noto Sans TC, English except for blog titles)
I like it myself.

https://jmes311chiyi.blogspot.com

@jancborchardt
Copy link
Member

@chiyi4488 could you test with the latest release, Nextcloud 15? This is where we added Nunito. It would be great if you can post some screenshots of how it looks for you. 🙂

@chiyi4488
Copy link
Contributor Author

15
16
17
19
21
22
23
24

@chiyi4488
Copy link
Contributor Author

Chinese is completely unchanged, exactly the same as the 14th edition.

@jancborchardt
Copy link
Member

jancborchardt commented Dec 22, 2018

@chiyi4488 ah right, I must have misread your suggestion, which sounds great:

When you update to the Nunito font, you can also add Noto Sans TC to Nunito. This will not affect the fonts you decide to add, also the Chinese font.

Would you like to contribute this as a pull request? This would be much appreciated! :)
Also, is it possible to ensure that it’s only loaded for when people actually choose Chinese as language? Because every additional font file which gets loaded will increase load time.

Thanks!

@chiyi4488
Copy link
Contributor Author

I am very willing, but I am not very familiar with the files of Nextcloud, if you are willing to tell me what files should be modified or added.I am willing to try (I don't know how to use the code, maybe I can't write it out at all.

@jancborchardt
Copy link
Member

@chiyi4488 cool! :)

I'm not sure about the conditional loading so it doesn't get loaded when Chinese is not selected as language. cc @nextcloud/javascript for help there.

@chiyi4488
Copy link
Contributor Author

chiyi4488 commented Feb 9, 2019

Hey friend, I found that with my current writing program ability, there is really no way to complete. I'm so sorry.QQ

@ghost

This comment has been minimized.

@ghost ghost added the stale Ticket or PR with no recent activity label Jun 12, 2019
@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Jun 12, 2019
@ghost ghost removed the stale Ticket or PR with no recent activity label Jun 12, 2019
@jancborchardt
Copy link
Member

We now use a native font stack as per #16055, this will be in Nextcloud 17. I think adding specific CJK fonts would not be necessary anymore as it will just use the system-provided one, correct?

@chiyi4488
Copy link
Contributor Author

not sure XXD. Chinese font is difficult to set (the computer does not necessarily set automatically)

XXD

@chiyi4488
Copy link
Contributor Author

chiyi4488 commented Jun 26, 2019

I haven't tested it yet (I accidentally deleted NC) XD #16055

@kesselb
Copy link
Contributor

kesselb commented Jan 1, 2020

cc @jancborchardt keep this open?

@jancborchardt
Copy link
Member

This is fixed already with Nextcloud 17, so we can close this. :) Thanks for the note @kesselb!

@jancborchardt
Copy link
Member

To clarify, this was fixed by: Use native font stack #16055

@chiyi4488
Copy link
Contributor Author

chiyi4488 commented Jan 3, 2020

@jancborchardt

I don't know if I don't understand CSS System Font, but as far as I know, I created this issue because microsoft Windows has set Chinese font sits that don't fit the web page.
This change, no change to the Chinese font...
That's why I wanted to use Noto Sans TC as web font

But if you want to use native fonts, I think you can change to Microsoft JhengHei.

TKSSS

@CL-Jeremy
Copy link

@chiyi4488 I have implemented this manually in the past for another project (in Less instead of Sass). The notes on various Chinese/CJK fonts as mentioned in zeripath/gitea#1 generally still apply.

I have been using Nextcloud mostly on macOS and everything looks just fine there: text is rendered to the corresponding variants for Simplified and Traditional Chinese, and for Korean and Japanese anyway. I suppose macOS does the job exceptionally well there. I will try and see if this is still an issue on Windows or an earlier version of macOS/OS X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement
Projects
None yet
Development

No branches or pull requests

8 participants