-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hope to add Chinese Font. #11640
Comments
Seems similar to #11299 - maybe we need to add more. @chiyi4488 Do you by any chance know if this is included in Open Sans somehow and what are the terms to check for? cc @jancborchardt because we looked into this last week. |
http://fonts.gstatic.com/ea/notosanstc/v1/OFL.txt I think this should not be in the open sans website, but I think this font should be free to use on the website. |
Note that we switched the main typeface to Nunito: https://fonts.google.com/specimen/Nunito. Noto is a good fallback, but maybe there’s even a rounded typeface supporting other character sets? |
What does it mean,it can support Chinese? |
If there is no way to support Chinese, the displayed font will not change. (if the user is Chinese) I think modifying the font is a good start, but it is recommended to set a multi-point font to support various languages. |
I have an idea. When you update to the Nunito font, you can also add Noto Sans TC to Nunito. This will not affect the fonts you decide to add, also the Chinese font. |
@chiyi4488 could you test with the latest release, Nextcloud 15? This is where we added Nunito. It would be great if you can post some screenshots of how it looks for you. 🙂 |
Chinese is completely unchanged, exactly the same as the 14th edition. |
@chiyi4488 ah right, I must have misread your suggestion, which sounds great:
Would you like to contribute this as a pull request? This would be much appreciated! :) Thanks! |
I am very willing, but I am not very familiar with the files of Nextcloud, if you are willing to tell me what files should be modified or added.I am willing to try (I don't know how to use the code, maybe I can't write it out at all. |
@chiyi4488 cool! :)
I'm not sure about the conditional loading so it doesn't get loaded when Chinese is not selected as language. cc @nextcloud/javascript for help there. |
Hey friend, I found that with my current writing program ability, there is really no way to complete. I'm so sorry.QQ |
This comment has been minimized.
This comment has been minimized.
We now use a native font stack as per #16055, this will be in Nextcloud 17. I think adding specific CJK fonts would not be necessary anymore as it will just use the system-provided one, correct? |
not sure XXD. Chinese font is difficult to set (the computer does not necessarily set automatically) XXD |
I haven't tested it yet (I accidentally deleted NC) XD #16055 |
cc @jancborchardt keep this open? |
This is fixed already with Nextcloud 17, so we can close this. :) Thanks for the note @kesselb! |
To clarify, this was fixed by: Use native font stack #16055 |
I don't know if I don't understand CSS System Font, but as far as I know, I created this issue because microsoft Windows has set Chinese font sits that don't fit the web page. But if you want to use native fonts, I think you can change to Microsoft JhengHei. TKSSS |
@chiyi4488 I have implemented this manually in the past for another project (in Less instead of Sass). The notes on various Chinese/CJK fonts as mentioned in zeripath/gitea#1 generally still apply. I have been using Nextcloud mostly on macOS and everything looks just fine there: text is rendered to the corresponding variants for Simplified and Traditional Chinese, and for Korean and Japanese anyway. I suppose macOS does the job exceptionally well there. I will try and see if this is still an issue on Windows or an earlier version of macOS/OS X. |
At present, the English font of nextcloud can be felt to have another design to match the beauty. But with us in Chinese, our fonts are very aesthetic (not usable, it is ugly).
I suggest to add Noto Sans TC (Chinese Traditional) font
This font perfectly fits the aesthetics of Chinese and English. Perhaps you can directly replace the original nextcloud fonts with this one.
I think this font should be copyright-free (http://fonts.gstatic.com/ea/notosanstc/v1/OFL.txt)
If there are copyright issues, I am very willing to look for other fonts again.
This is the font URL
https://fonts.google.com/specimen/Noto+Sans+TC
Https://www.google.com/get/noto/help/cjk/
Https://www.google.com/get/noto/
Also, please add this message to your considerations.
Traditional Chinese (Taiwan, Hong Kong) is different from Simplified Chinese (China)
So you need to distinguish the fonts.
This will make nextcloud more and more perfect. I know this is very difficult. After all, each language has different fonts. I hope to use Chinese as a first step to slowly perfect each language.
Sincere hope can take my opinion, thank you.
The text was updated successfully, but these errors were encountered: