We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shutdown hooks calls process.kill when it has finished the shutdown this skips process Event exit getting called.
process.kill
exit
https://nodejs.org/api/process.html#event-exit the exit event is used by e.g. pino (using on-exit-leak-free) to flush the logs before exiting.
/~https://github.com/pinojs/pino/blob/ad864b7ae02b314b9a548614f705a437e0db78c3/lib/transport.js#L10-L19
https://codesandbox.io/p/sandbox/sad-noyce-6zrk6c
https://nodejs.org/api/process.html#event-exit should be called
@nestjs/common
@nestjs/core
@nestjs/microservices
@nestjs/platform-express
@nestjs/platform-fastify
@nestjs/platform-socket.io
@nestjs/platform-ws
@nestjs/testing
@nestjs/websockets
No response
{ "name": "nest-typescript-starter", "private": true, "version": "1.0.0", "description": "Nest TypeScript starter repository", "license": "MIT", "scripts": { "build": "nest build", "format": "prettier --write \"src/**/*.ts\" \"test/**/*.ts\"", "start": "nest start", "start:dev": "nest start --watch", "start:debug": "nest start --debug --watch", "start:prod": "node dist/main", "lint": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix", "test": "jest", "test:watch": "jest --watch", "test:cov": "jest --coverage", "test:debug": "node --inspect-brk -r tsconfig-paths/register -r ts-node/register node_modules/jest/bin/jest --runInBand", "test:e2e": "jest --config ./test/jest-e2e.json" }, "engines": { "npm": ">=8.0.0", "node": ">=16.0.0" }, "dependencies": { "@nestjs/common": "^10.3.2", "@nestjs/core": "^10.4.4", "@nestjs/platform-express": "^10.4.4", "reflect-metadata": "^0.2.1", "rxjs": "^7.8.1" }, "devDependencies": { "@nestjs/cli": "^10.4.5", "@nestjs/schematics": "^10.1.0", "@nestjs/testing": "^10.3.2", "@swc/cli": "^0.3.9", "@swc/core": "^1.4.0", "@types/express": "^4.17.21", "@types/jest": "^29.5.12", "@types/node": "^20.11.16", "@types/supertest": "^6.0.2", "@typescript-eslint/eslint-plugin": "^6.21.0", "@typescript-eslint/parser": "^6.21.0", "eslint": "^8.56.0", "eslint-config-prettier": "^9.1.0", "eslint-plugin-prettier": "^5.1.3", "jest": "^29.7.0", "prettier": "^3.2.5", "source-map-support": "^0.5.21", "supertest": "^6.3.4", "ts-jest": "^29.1.2", "ts-loader": "^9.5.1", "ts-node": "^10.9.2", "tsconfig-paths": "^4.2.0", "typescript": "^5.3.3" }, "jest": { "moduleFileExtensions": [ "js", "json", "ts" ], "rootDir": "src", "testRegex": ".*\\.spec\\.ts$", "transform": { "^.+\\.(t|j)s$": "ts-jest" }, "collectCoverageFrom": [ "**/*.(t|j)s" ], "coverageDirectory": "../coverage", "testEnvironment": "node" } }
The text was updated successfully, but these errors were encountered:
Fix process not ending correctly with shutdown hooks
56af69c
fixes nestjs#14432 https://codesandbox.io/p/sandbox/sad-noyce-6zrk6c
Successfully merging a pull request may close this issue.
Is there an existing issue for this?
Current behavior
Shutdown hooks calls
process.kill
when it has finished the shutdown this skips process Eventexit
getting called.https://nodejs.org/api/process.html#event-exit the exit event is used by e.g. pino (using on-exit-leak-free) to flush the logs before exiting.
/~https://github.com/pinojs/pino/blob/ad864b7ae02b314b9a548614f705a437e0db78c3/lib/transport.js#L10-L19
Minimum reproduction code
https://codesandbox.io/p/sandbox/sad-noyce-6zrk6c
Steps to reproduce
Expected behavior
https://nodejs.org/api/process.html#event-exit should be called
Package
@nestjs/common
@nestjs/core
@nestjs/microservices
@nestjs/platform-express
@nestjs/platform-fastify
@nestjs/platform-socket.io
@nestjs/platform-ws
@nestjs/testing
@nestjs/websockets
Other package
No response
NestJS version
No response
Packages versions
Node.js version
No response
In which operating systems have you tested?
Other
No response
The text was updated successfully, but these errors were encountered: