Brown and pink aren't handled correctly in unifieddyes.get_color_from_dye_name

[wsor4035]

Brown and pink aren't handled correctly in unifieddyes.get_color_from_dye_name
For brown and pink dyes (alias medium_orange and light_red) no useful value is returned from unifieddyes.get_color_from_dye_name.

I'm not sure if this also affects other APIs, so I didn't create a Merge Request myself.

I'll append the correct hex codes, in case they are needed for an easier fix:

light_red: #ff5050
medium_orange: #b43500

[wsor4035]

Vanessa Dannenberg @VanessaE · 1 year ago
Maintainer
Brown and pink have been kinda a thorn in my side since the advent of this mod. Their handling is inconsistent and not always logical... and that's mostly my fault 😛

The whole mod kinda needs an overhaul.

Edited by Vanessa Dannenberg 1 year ago

[wsor4035]

SwissalpS @SwissalpS · 11 months ago
There are also duplicate hex values returned by that function for different colour names. Using this snippet and a linter on the output, you will get a list of duplicates.

Did I understand the system wrong, isn't every colour name supposed to identify a unique colour?