Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_nonlincausality Arguments not filled #7

Open
cloudy-sfu opened this issue Oct 3, 2023 · 2 comments
Open

run_nonlincausality Arguments not filled #7

cloudy-sfu opened this issue Oct 3, 2023 · 2 comments

Comments

@cloudy-sfu
Copy link

verbose,
plot,
"LSTM",

The three argument is not aligned to the definition of run_nonlincausality and will cause the following issue:

TypeError: run_nonlincausality() missing 3 required positional arguments: 'verbose', 'plot', and 'functin_type'

Suggestion:

verbose=verbose,
plot=plot,
function_type='LSTM'

The same thing should be fixed in the definitions of other neural network types.

@cloudy-sfu cloudy-sfu changed the title Argument not filled run_nonlincausality Arguments not filled Oct 3, 2023
@cloudy-sfu
Copy link
Author

cloudy-sfu commented Oct 3, 2023

The following issue is caused by the same problem, but the solution doesn't solve the problem essentially.

#3 (comment)
#4 (comment)

@amml1
Copy link

amml1 commented Jan 10, 2024

The issue seems to come from the fact, that there are two arguments (x_val and z_val) defined in run_nonlincausality but not in run_nonlincausalityMLP or run_nonlincausalityLSTM, why you get this error for both functions. There is no description of the two arguments either in utils.py or run_nonlincausality.py. In run_nonlincausalityNN they are defined, but you get another error: X_val = x_val[lag:, 0]
line 149 TypeError: list indices must be integers or slices, not tuple. The idea for this package is great, I hope the issue can be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants