From 9b3bbd53a2004f7081dc44f4c06819beee2457cd Mon Sep 17 00:00:00 2001 From: Anders Hartvoll Ruud Date: Wed, 21 Dec 2022 03:10:06 -0800 Subject: [PATCH] Apply length conversion flags for incremental styles Incremental style resolutions never enter ApplyBaseStyleNoCache, which is where ApplyLengthConversionFlags normally happens. Call this function for incremental styling as well. Note: There's already a call to ApplyLengthConversionFlags in ApplyAnimatedStyle, so there should not be a similar issue for the base ComputedStyle optimization. Fixed: 1402548 Change-Id: I8fafb495c52c1c209d9b59b20e472ce489ad560a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4116982 Commit-Queue: Anders Hartvoll Ruud Reviewed-by: Rune Lillesveen Cr-Commit-Position: refs/heads/main@{#1085846} --- .../crashtests/viewport-unit-inline-style-crash.html | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 css/css-values/crashtests/viewport-unit-inline-style-crash.html diff --git a/css/css-values/crashtests/viewport-unit-inline-style-crash.html b/css/css-values/crashtests/viewport-unit-inline-style-crash.html new file mode 100644 index 00000000000000..4c38e18781bfdb --- /dev/null +++ b/css/css-values/crashtests/viewport-unit-inline-style-crash.html @@ -0,0 +1,11 @@ + +Don't crash when setting viewport units on inline style + +
+ PASS if no crash +
+