Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add author, copyright, and license annotations? #3611

Open
casella opened this issue Nov 12, 2024 · 2 comments
Open

Add author, copyright, and license annotations? #3611

casella opened this issue Nov 12, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@casella
Copy link
Collaborator

casella commented Nov 12, 2024

The FMI standard optionally allows this information to be stored in an FMU

immagine

When generating FMUs from a Modelica model, every tool will have its own way to get this information. Regarding version, it can take it from the annotation with the same name. Should we add annotation to provide also the other pieces of information?

@HansOlsson
Copy link
Collaborator

For license texts it was added in #2900 and such files already exist now in MSL (and tools use them when appropriate).

The important part is that there may be multiple relevant licenses for a model (if it uses multiple libraries and/or functions), and all of them should be added (as in that MCP).

For copyright and author it is also complicated - and I would say that the FMI is derived work from the models it uses and the tool(s) generating it. That means that we cannot generate one copyright and one author based on that (and keeping that information up-to-date for all models will also be complicated). I thus don't think we can just add it.

One could even say that the one generating the FMU is its author and copyright holder (and that copyright holder will then have to deal with the copyright of the parts it was derived from), i.e., separate from anything in Modelica.

@HansOlsson
Copy link
Collaborator

I thus see so many problems with maintaining that information that I don't think that adding these fields will be a benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants