Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad default color in dark themes if semantic token type is not defined #89440

Closed
dbaeumer opened this issue Jan 28, 2020 · 6 comments
Closed

Bad default color in dark themes if semantic token type is not defined #89440

dbaeumer opened this issue Jan 28, 2020 · 6 comments
Assignees
@aeschli
Milestone
January 2020

Comments

@dbaeumer
Copy link
Member

capture
@aeschli aeschli added this to the January 2020 milestone Jan 29, 2020
@aeschli
Copy link
Contributor

aeschli commented Jan 29, 2020

caused by #89600

@dbaeumer
Copy link
Member Author

Thanks for fixing. Works nice now.

@dbaeumer
Copy link
Member Author

Except one little thing.

capture

Observe: provideCompletionItems is colored in white whereas resolveCompletionItem is colored correctly (or better)

@dbaeumer
Copy link
Member Author

capture

@aeschli
Copy link
Contributor

aeschli commented Jan 30, 2020 •
edited
Loading

No semantic highlighting is involved here. It's a TextMate grammar issue.

@dbaeumer It's not related to the original issue. Either file an issue against the TS grammar (/~https://github.com/Microsoft/TypeScript-TmLanguage) or a issue against me to add semantic highlighting here.

@aeschli aeschli closed this as completed Jan 30, 2020
@dbaeumer
Copy link
Member Author

Created #89716 and assigned to you (since more likely to get a fix :-))

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
January 2020
Development

No branches or pull requests
2 participants
@dbaeumer @aeschli