Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Indent Detection to set indentSize to auto rather than tabSize #203504

Open
ParadoxV5 opened this issue Jan 26, 2024 · 0 comments
Open
Assignees
Labels
debt Code quality issues editor-indent-detection Issues around the guessing of indentation for files

Comments

@ParadoxV5
Copy link

I can tell that VSCode historically used tabSize and no indentSize. indentSize is a relatively new concept ((still) incompletely) introduced in #155450, but Indent Detection (and possibly other features as well) is still in the past and not migrated to use indentSize (such as #193811). Problems arise with this inconsistency, such as

Request: Finish this mess up and migrate Indent Detection from tabSize: 'auto' to indentSize: 'auto'.

Background: I indent with spaces, yes, but I like my tabs extra long for, well, tabulation, that’s what ‘tab’ stands for.

(Really, if indentSize is still half-baked, why is it in production (stable versions) already?)

indentSize: guessedIndentation.tabSize, // TODO@Alex: guess indentSize independent of tabSize

@ParadoxV5 ParadoxV5 moved this to 🗳️ Submitted in General Projects Jan 26, 2024
@sandy081 sandy081 assigned alexdima and unassigned sandy081 Jan 26, 2024
@rebornix rebornix added the editor-indent-detection Issues around the guessing of indentation for files label Dec 19, 2024
@rebornix rebornix assigned aiday-mar and unassigned alexdima Dec 19, 2024
@connor4312 connor4312 added the debt Code quality issues label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues editor-indent-detection Issues around the guessing of indentation for files
Projects
None yet
Development

No branches or pull requests

7 participants