Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CMake 3.21 and CMakePresets.json v3 files #1904

Closed
esweet431 opened this issue May 26, 2021 · 6 comments
Closed

Add support for CMake 3.21 and CMakePresets.json v3 files #1904

esweet431 opened this issue May 26, 2021 · 6 comments
Assignees
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: presets
Milestone

Comments

@esweet431
Copy link
Contributor

Kitware is incrementing the version of CMakePresets.json files in CMake 3.21. We need to support CMakePresets.json v3 files and CMake 3.21 in cmake-tools.

@esweet431
Copy link
Contributor Author

esweet431 commented Jun 9, 2021

In addition to supporting v3 files, there are also some features we can light up in the extension.

  • Respect any specified condition(s) when surfacing presets for selection. If the preset is not enabled then it should not be available for selection. We will continue to support our "hostOS" object (for at least a few releases).
  • Provide IntelliSense for installDir and toolchainFile in CMakePresets.json. Add note to description of cacheVariables.CMAKE_INSTALL_PREFIX and cacheVariables.CMAKE_TOOLCHAIN_FILE to use root level objects (installDir and toolchainFile) in cases where the user is using a file with version >= 3.

Edited to not include changes to our templates.

@andreeis andreeis added enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: presets labels Jun 10, 2021
@andreeis andreeis added this to the 1.9.0 milestone Jun 22, 2021
@KUGA2
Copy link

KUGA2 commented Jul 15, 2021

CMake 3.21 is now released. Do you have a plan when this will be availible in cmake-tools?
Or at least make the parser less picky.

@anb0s
Copy link

anb0s commented Sep 15, 2021

We have also switched to CMakePresets.json v3 and wanted to use toolchainFile instead of cacheVariables.CMAKE_TOOLCHAIN_FILE because CMake shows warning during build step. Is there a timeline for release of next plugin version or a beta release? Thanks!

@bobbrow
Copy link
Member

bobbrow commented Sep 15, 2021

@anb0s thanks for asking. You can try a preview of this feature by following these steps:

  1. Download the build artifact from here: /~https://github.com/microsoft/vscode-cmake-tools/suites/3758389143/artifacts/92322935
  2. Unzip the VSIX file
  3. Run the Install from VSIX... command and select the VSIX file.

Let us know if you have any issues with it.

@anb0s
Copy link

anb0s commented Oct 15, 2021

verified with 1.9.0 - the v3 is supported

@anb0s
Copy link

anb0s commented Oct 15, 2021

have other issue now, see #2179

@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: presets
Projects
None yet
Development

No branches or pull requests

6 participants