Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate FUNCTIONS_WORKER_RUNTIME is defined #1239

Closed
asavaritayal opened this issue Apr 29, 2019 · 3 comments
Closed

Validate FUNCTIONS_WORKER_RUNTIME is defined #1239

asavaritayal opened this issue Apr 29, 2019 · 3 comments
Milestone

Comments

@asavaritayal
Copy link

asavaritayal commented Apr 29, 2019

After this message -

image

Prompt the user to pick a language for their project and initialize it as the FUNCTIONS_WORKER_RUNTIME setting in the local.settings.json file.

This'll ensure that the user is set up for success to run/debug functions locally.

@ejizba
Copy link
Contributor

ejizba commented May 7, 2019

@asavaritayal I don't think the timing of that prompt matches up with what you want. That prompt happens because they have a project they created with the func cli (or elsewhere) and are opening it in VS Code for the first time. In many cases, FUNCTIONS_WORKER_RUNTIME should already be set.

I believe you want us to somehow validate for the case when local.settings.json is deleted because it's not tracked by source control (similar to Azure/azure-functions-core-tools#1261), but I'm not sure when that should happen. Also I think adding FUNCTIONS_WORKER_RUNTIME to source control is the true fix: Azure/azure-functions-host#3120

@ejizba ejizba changed the title Set FUNCTIONS_WORKER_RUNTIME on project initialization Validate FUNCTIONS_WORKER_RUNTIME is defined May 7, 2019
@ejizba
Copy link
Contributor

ejizba commented Sep 12, 2019

Note to self: Did I fix this already?

@ejizba
Copy link
Contributor

ejizba commented Sep 12, 2019

Fixed in #1431

@ejizba ejizba closed this as completed Sep 12, 2019
@ejizba ejizba added this to the 0.18.0 milestone Sep 12, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants