-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mocha Test id depends on the file path #1561
Comments
Which version of VS and the Node Tools for VS are you using? |
TFS 2015 build agent with VS 2015, NTVS tools is based on 1.3 plus private changes done by @ozyx and pushed to you (as the project). |
@fforjan Any progress on this work? i.e. should I push out a new 1.3 drop, or wait for this? |
@ozyx was away and should be back tomorrow, I will discuss with him and give you a status |
@paulvanbrenk Currently working on this now, will have a PR for you either today or tomorrow. EDIT: See #1605 |
Awesome, going to take a look tomorrow. @billti feel free to swipe this from me |
This is now also fixed in VS 2017 |
When running javascript unit test via Mocha on a TFS build, TFS is not able to detect that the test was failing in a previous build and tag as failing in the current build
Expected Behavior
same test failing in consecutive build should be detected as failing in the first build.
Actual Behavior
same test failing in consecutive build is not detected as failed in the first build
Steps to Reproduce
My assumption about this issue is about the test having some file path in its ID. the file path depends on the workspace location and is different between build agents:
Build A :
Build A + 1
Which seems to be related to the fully qualified name : /~https://github.com/Microsoft/nodejstools/blob/master/Nodejs/Product/TestAdapter/TestFrameworks/NodejsTestInfo.cs#L42
On regular C# unit tests, you can see the ID seems to not only include the file name but the class name which should be the unique ID
The text was updated successfully, but these errors were encountered: