[SPIR-V] enable [[vk::ext_decorate/_id/_string]] for struct/class fields or function parameter
#4195
Comments
s-perron
added a commit
to s-perron/DirectXShaderCompiler
that referenced
this issue
Feb 11, 2025
This commit implements adding the `vk::ext_decorate` on a field. It also adds an error in sema if `vk::ext_decorate_id` or `vk::ext_decorate_string` are used on members. For `vk::ext_decorate_id`, there is no `OpMemberDecorateId` instruction, so we cannot add apply these decorations to members. For `vk::ext_decorate_string`, there is only one decoration that uses OpDecorateString or OpMemberDecorateString, UserSemantic. However, that decoration could have used OpDecorate or OpMemberDecorate because those instructions accept string literals. I do not expect any new decorations to use OpDecorateString or OpMemberDecorateString. I may eventually want to deprecate `vk::ext_decorate_string`. Fixes microsoft#4195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a part of HLSL version of GL_EXT_spirv_intrinsics (#3919), we have to enable
[[vk::ext_decorate/_id/_string]]for struct/class fields or function parameter.The text was updated successfully, but these errors were encountered: