Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong notification shown while creating merge request #441

Closed
ayusht2810 opened this issue Jan 16, 2024 · 1 comment
Closed

Wrong notification shown while creating merge request #441

ayusht2810 opened this issue Jan 16, 2024 · 1 comment

Comments

@ayusht2810
Copy link
Contributor

Description

When a user assigns a merge request to another user before creating the merge request, the assignee gets a notification of requested review instead of assigned merge request.

Steps to reproduce

  1. Start creating a merge request on GtiLab.
  2. Before creating a merge request, add an assignee to the merge request.
  3. Create the merge request.
  4. Check the notification received on the Mattermost.

Expected behaviour

Should show notification for assignment of the merge request

Actual behaviour

Notification received for the review request on the merge request

Additional context

This might be due to the fact that we are simply showing requested your review at line instead of checking whether the notification was for assignment of merge request or due to request review.

@ayusht2810
Copy link
Contributor Author

Fixed by #471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant