From 2074acd001115dd4c60d432e71a4fef58794c881 Mon Sep 17 00:00:00 2001 From: Marian13 Date: Sun, 10 Sep 2023 23:49:43 +0300 Subject: [PATCH] refactor(has_j_send_result_short)!: update constants --- .../plugins/has_j_send_result/constants.rb | 8 ++++---- .../plugins/has_j_send_result/constants_spec.rb | 16 ++++++++-------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/convenient_service/service/plugins/has_j_send_result/constants.rb b/lib/convenient_service/service/plugins/has_j_send_result/constants.rb index f5f6678415d..78633b131fc 100644 --- a/lib/convenient_service/service/plugins/has_j_send_result/constants.rb +++ b/lib/convenient_service/service/plugins/has_j_send_result/constants.rb @@ -11,14 +11,14 @@ module Constants DEFAULT_SUCCESS_DATA = {} DEFAULT_FAILURE_DATA = {} - ERROR_DATA = {} + DEFAULT_ERROR_DATA = {} - SUCCESS_MESSAGE = "" + DEFAULT_SUCCESS_MESSAGE = "" DEFAULT_FAILURE_MESSAGE = "" DEFAULT_ERROR_MESSAGE = "" - SUCCESS_CODE = :success - FAILURE_CODE = :failure + DEFAULT_SUCCESS_CODE = :default_success + DEFAULT_FAILURE_CODE = :default_failure DEFAULT_ERROR_CODE = :default_error end end diff --git a/spec/lib/convenient_service/service/plugins/has_j_send_result/constants_spec.rb b/spec/lib/convenient_service/service/plugins/has_j_send_result/constants_spec.rb index 4ae725addef..938535edd95 100644 --- a/spec/lib/convenient_service/service/plugins/has_j_send_result/constants_spec.rb +++ b/spec/lib/convenient_service/service/plugins/has_j_send_result/constants_spec.rb @@ -36,15 +36,15 @@ end end - describe "::ERROR_DATA" do + describe "::DEFAULT_ERROR_DATA" do it "returns empty hash" do - expect(described_class::ERROR_DATA).to eq({}) + expect(described_class::DEFAULT_ERROR_DATA).to eq({}) end end - describe "::SUCCESS_MESSAGE" do + describe "::DEFAULT_SUCCESS_MESSAGE" do it "returns empty string" do - expect(described_class::SUCCESS_MESSAGE).to eq("") + expect(described_class::DEFAULT_SUCCESS_MESSAGE).to eq("") end end @@ -60,15 +60,15 @@ end end - describe "::SUCCESS_CODE" do + describe "::DEFAULT_SUCCESS_CODE" do it "returns `:success`" do - expect(described_class::SUCCESS_CODE).to eq(:success) + expect(described_class::DEFAULT_SUCCESS_CODE).to eq(:default_success) end end - describe "::FAILURE_CODE" do + describe "::DEFAULT_FAILURE_CODE" do it "returns `:failure`" do - expect(described_class::FAILURE_CODE).to eq(:failure) + expect(described_class::DEFAULT_FAILURE_CODE).to eq(:default_failure) end end