Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fibonacci benchmark improvements #782

Closed
huitseeker opened this issue Oct 23, 2023 · 1 comment · Fixed by #784
Closed

Fibonacci benchmark improvements #782

huitseeker opened this issue Oct 23, 2023 · 1 comment · Fixed by #784

Comments

@huitseeker
Copy link
Contributor

Duplication and Architecture

  • Minimize code duplication between the Fibonacci and Fibonacci_LEM benchmarks by refactoring common code into shared functions or modules.
  • Follow the Criterion architecture for comparing functions to organize and compare the benchmarks, which will enable plotting the performance of these benchmarks relative to each other.

BenchmarkID Construction

Performance Measurement
@winston-h-zhang winston-h-zhang mentioned this issue Oct 23, 2023
Merged
@huitseeker huitseeker reopened this Oct 30, 2023
huitseeker added a commit to huitseeker/lurk-rs that referenced this issue Oct 30, 2023
@huitseeker
chore: Enhance benchmark setup and update rust-toolchain
b243972 
- Enhanced identification and tracking for benchmarks by moving 'date' and 'sha' fields to `ProveParams` struct.
- Tuned the `fibo_prove` function to utilize the new fields for better benchmark IDs (see lurk-lab#782)
- Updated `rust-toolchain` version from `1.72.1` to `1.73.0` enhancing overall runtime environment.
- Counted throughput in frames / s.

This performs the straightforward parts of lurk-lab#782, re-opened after lurk-lab#784 was reverted (in lurk-lab#808)
@huitseeker huitseeker mentioned this issue Oct 30, 2023
Merged
huitseeker added a commit to huitseeker/lurk-rs that referenced this issue Oct 30, 2023
@huitseeker
chore: Enhance benchmark setup and update rust-toolchain
0ce0ef1 
- Enhanced identification and tracking for benchmarks by moving 'date' and 'sha' fields to `ProveParams` struct.
- Tuned the `fibo_prove` function to utilize the new fields for better benchmark IDs (see lurk-lab#782)
- Updated `rust-toolchain` version from `1.72.1` to `1.73.0` enhancing overall runtime environment.
- Counted throughput in frames / s.

This performs the straightforward parts of lurk-lab#782, re-opened after lurk-lab#784 was reverted (in lurk-lab#808)
huitseeker added a commit to huitseeker/lurk-rs that referenced this issue Oct 31, 2023
@huitseeker
chore: Enhance benchmark setup and update rust-toolchain
794b00d 
- Enhanced identification and tracking for benchmarks by moving 'date' and 'sha' fields to `ProveParams` struct.
- Tuned the `fibo_prove` function to utilize the new fields for better benchmark IDs (see lurk-lab#782)
- Updated `rust-toolchain` version from `1.72.1` to `1.73.0` enhancing overall runtime environment.
- Counted throughput in frames / s.

This performs the straightforward parts of lurk-lab#782, re-opened after lurk-lab#784 was reverted (in lurk-lab#808)
huitseeker added a commit to huitseeker/lurk-rs that referenced this issue Oct 31, 2023
@huitseeker
chore: Enhance benchmark setup and update rust-toolchain
88010f2 
- Enhanced identification and tracking for benchmarks by moving 'date' and 'sha' fields to `ProveParams` struct.
- Tuned the `fibo_prove` function to utilize the new fields for better benchmark IDs (see lurk-lab#782)
- Updated `rust-toolchain` version from `1.72.1` to `1.73.0` enhancing overall runtime environment.
- Counted throughput in frames / s.

This performs the straightforward parts of lurk-lab#782, re-opened after lurk-lab#784 was reverted (in lurk-lab#808)
huitseeker added a commit to huitseeker/lurk-rs that referenced this issue Oct 31, 2023
@huitseeker
chore: Enhance benchmark setup and update rust-toolchain
518f587 
- Enhanced identification and tracking for benchmarks by moving 'date' and 'sha' fields to `ProveParams` struct.
- Tuned the `fibo_prove` function to utilize the new fields for better benchmark IDs (see lurk-lab#782)
- Updated `rust-toolchain` version from `1.72.1` to `1.73.0` enhancing overall runtime environment.
- Counted throughput in frames / s.

This performs the straightforward parts of lurk-lab#782, re-opened after lurk-lab#784 was reverted (in lurk-lab#808)
huitseeker added a commit to huitseeker/lurk-rs that referenced this issue Oct 31, 2023
@huitseeker
chore: Enhance benchmark setup and update rust-toolchain
34ea708 
- Enhanced identification and tracking for benchmarks by moving 'date' and 'sha' fields to `ProveParams` struct.
- Tuned the `fibo_prove` function to utilize the new fields for better benchmark IDs (see lurk-lab#782)
- Updated `rust-toolchain` version from `1.72.1` to `1.73.0` enhancing overall runtime environment.
- Counted throughput in frames / s.

This performs the straightforward parts of lurk-lab#782, re-opened after lurk-lab#784 was reverted (in lurk-lab#808)
github-merge-queue bot pushed a commit that referenced this issue Oct 31, 2023
@huitseeker
chore: Enhance benchmark setup and update rust-toolchain (#814)
a3d0ed1 
* chore: Enhance benchmark setup and update rust-toolchain

- Enhanced identification and tracking for benchmarks by moving 'date' and 'sha' fields to `ProveParams` struct.
- Tuned the `fibo_prove` function to utilize the new fields for better benchmark IDs (see #782)
- Updated `rust-toolchain` version from `1.72.1` to `1.73.0` enhancing overall runtime environment.
- Counted throughput in frames / s.

This performs the straightforward parts of #782, re-opened after #784 was reverted (in #808)

* chore:clippy

* fix: adjust test post toolchain update

* fix: permute rc param and fib_n
@huitseeker
Copy link
Contributor Author

Fixed in #852 #855 #857 #861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Merge and improve fibonacci benchmarks lurk-lab/lurk-beta
1 participant
@huitseeker