Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No setup instructions for Android #10

Open
pablomayobre opened this issue Jun 10, 2017 · 2 comments
Open

No setup instructions for Android #10

pablomayobre opened this issue Jun 10, 2017 · 2 comments

Comments

@pablomayobre
Copy link

This is more of a complaint hahaha... But since there are instructions for iOS in the README it would be better to add Android instructions too, to keep it complete.

For a moment I thought Android was not supported by this library, so only showing instructions for iOS can be confusing.
@scarmuega
Copy link
Collaborator

@positive07 I agree. Would you like to send a PR with an updated README?

@pablomayobre
Copy link
Author

pablomayobre commented Jun 12, 2017 •
edited
Loading

Sorry but I haven't tried to compile this module with Android just yet. Instruction would probably be similar to the ones shown in section 2 of Android Guide for firebase-react-native but I should try it first.

If anyone has feedback please at least post it here, it will be really helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scarmuega @pablomayobre