Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expiring peerstore data #3017

Open
achingbrain opened this issue Feb 27, 2025 · 0 comments · May be fixed by #3019
Open

Expiring peerstore data #3017

achingbrain opened this issue Feb 27, 2025 · 0 comments · May be fixed by #3019
Labels
exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature

Comments

@achingbrain
Copy link
Member

The peerstore needs to be smarter about expiring old data and evicting older peers.

  • Multiaddrs should expire after a timeout - go-libp2p uses one hour
  • Peers without multiaddrs should be evicted after a period of time, perhaps six hours
  • The multiaddr removal/eviction could be done while calling .all/.get on the peerstore
@achingbrain achingbrain added need/triage Needs initial labeling and prioritization kind/enhancement A net-new feature or improvement to an existing feature exp/intermediate Prior experience is likely helpful and removed need/triage Needs initial labeling and prioritization labels Feb 27, 2025
achingbrain added a commit that referenced this issue Feb 28, 2025
@achingbrain
feat: expire peerstore data
4d1b1e4 
Expires peer store multiaddrs after an hour and removes peer store
peers after six hours if their addresses have not been updated.

Fixes #3017
@achingbrain achingbrain linked a pull request Feb 28, 2025 that will close this issue
Open
3 tasks
achingbrain added a commit that referenced this issue Feb 28, 2025
@achingbrain
feat: expire peerstore data
71c2b9d 
Expires peer store multiaddrs after an hour and removes peer store
peers after six hours if their addresses have not been updated.

Fixes #3017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: expire peerstore data libp2p/js-libp2p
1 participant
@achingbrain