From e0a177a9d7ed61cb7f622abb84566b13ee03b7b2 Mon Sep 17 00:00:00 2001
From: KV <kvid@users.noreply.github.com>
Date: Sat, 20 Feb 2021 00:21:22 +0100
Subject: [PATCH] Support both bgcolor and bgcolor_title attributes

Solves #210 completely by supporting bgcolor of both the node title
and the whole node independently using separate attributes.
---
 docs/syntax.md             |  2 ++
 src/wireviz/DataClasses.py |  2 ++
 src/wireviz/Harness.py     | 13 ++++++++-----
 src/wireviz/wv_gv_html.py  | 12 ++++++++----
 4 files changed, 20 insertions(+), 9 deletions(-)

diff --git a/docs/syntax.md b/docs/syntax.md
index b83d7789..255f6110 100644
--- a/docs/syntax.md
+++ b/docs/syntax.md
@@ -63,6 +63,7 @@ additional_bom_items:  # custom items to add to BOM
 
   # rendering information (all optional)
   bgcolor: <color>       # Background color of diagram connector box
+  bgcolor_title: <color> # Background color of title in diagram connector box
   style: <style>         # may be set to simple for single pin connectors
   show_name: <bool>      # defaults to true for regular connectors,
                          # false for simple connectors
@@ -139,6 +140,7 @@ Since the auto-incremented and auto-assigned designator is not known to the user
 
   # rendering information (all optional)
   bgcolor: <color>          # Background color of diagram cable box
+  bgcolor_title: <color>    # Background color of title in diagram cable box
   show_name: <bool>         # defaults to true
   show_wirecount: <bool>    # defaults to true
   show_wirenumbers: <bool>  # defaults to true for cables; false for bundles
diff --git a/src/wireviz/DataClasses.py b/src/wireviz/DataClasses.py
index fbccdcb7..a4473821 100644
--- a/src/wireviz/DataClasses.py
+++ b/src/wireviz/DataClasses.py
@@ -86,6 +86,7 @@ def description(self) -> str:
 class Connector:
     name: Designator
     bgcolor: Optional[Color] = None
+    bgcolor_title: Optional[Color] = None
     manufacturer: Optional[MultilineHypertext] = None
     mpn: Optional[MultilineHypertext] = None
     pn: Optional[Hypertext] = None
@@ -169,6 +170,7 @@ def get_qty_multiplier(self, qty_multiplier: Optional[ConnectorMultiplier]) -> i
 class Cable:
     name: Designator
     bgcolor: Optional[Color] = None
+    bgcolor_title: Optional[Color] = None
     manufacturer: Union[MultilineHypertext, List[MultilineHypertext], None] = None
     mpn: Union[MultilineHypertext, List[MultilineHypertext], None] = None
     pn: Union[Hypertext, List[Hypertext], None] = None
diff --git a/src/wireviz/Harness.py b/src/wireviz/Harness.py
index b3b0dcc0..79bd4e96 100644
--- a/src/wireviz/Harness.py
+++ b/src/wireviz/Harness.py
@@ -11,7 +11,8 @@
 from wireviz import wv_colors, __version__, APP_NAME, APP_URL
 from wireviz.DataClasses import Connector, Cable
 from wireviz.wv_colors import get_color_hex
-from wireviz.wv_gv_html import nested_html_table, html_bgcolor, html_colorbar, \
+from wireviz.wv_gv_html import nested_html_table, \
+    html_bgcolor_attr, html_bgcolor, html_colorbar, \
     html_image, html_caption, remove_links, html_line_breaks
 from wireviz.wv_bom import manufacturer_info_field, component_table_entry, \
     get_additional_component_table, bom_list, generate_bom
@@ -117,7 +118,8 @@ def create_graph(self) -> Graph:
 
             html = []
 
-            rows = [[f'{html_bgcolor(connector.bgcolor)}{remove_links(connector.name)}' if connector.show_name else None],
+            rows = [[f'{html_bgcolor(connector.bgcolor_title)}{remove_links(connector.name)}'
+                        if connector.show_name else None],
                     [f'P/N: {remove_links(connector.pn)}' if connector.pn else None,
                      html_line_breaks(manufacturer_info_field(connector.manufacturer, connector.mpn))],
                     [html_line_breaks(connector.type),
@@ -129,7 +131,7 @@ def create_graph(self) -> Graph:
                     [html_caption(connector.image)]]
             rows.extend(get_additional_component_table(self, connector))
             rows.append([html_line_breaks(connector.notes)])
-            html.extend(nested_html_table(rows))
+            html.extend(nested_html_table(rows, html_bgcolor_attr(connector.bgcolor)))
 
             if connector.style != 'simple':
                 pinhtml = []
@@ -198,7 +200,8 @@ def create_graph(self) -> Graph:
                 elif cable.gauge_unit.upper() == 'AWG':
                     awg_fmt = f' ({mm2_equiv(cable.gauge)} mm\u00B2)'
 
-            rows = [[f'{html_bgcolor(cable.bgcolor)}{remove_links(cable.name)}' if cable.show_name else None],
+            rows = [[f'{html_bgcolor(cable.bgcolor_title)}{remove_links(cable.name)}'
+                        if cable.show_name else None],
                     [f'P/N: {remove_links(cable.pn)}' if (cable.pn and not isinstance(cable.pn, list)) else None,
                      html_line_breaks(manufacturer_info_field(
                         cable.manufacturer if not isinstance(cable.manufacturer, list) else None,
@@ -215,7 +218,7 @@ def create_graph(self) -> Graph:
 
             rows.extend(get_additional_component_table(self, cable))
             rows.append([html_line_breaks(cable.notes)])
-            html.extend(nested_html_table(rows))
+            html.extend(nested_html_table(rows, html_bgcolor_attr(cable.bgcolor)))
 
             wirehtml = []
             wirehtml.append('<table border="0" cellspacing="0" cellborder="0">')  # conductor table
diff --git a/src/wireviz/wv_gv_html.py b/src/wireviz/wv_gv_html.py
index 0be23602..c96388e6 100644
--- a/src/wireviz/wv_gv_html.py
+++ b/src/wireviz/wv_gv_html.py
@@ -1,20 +1,20 @@
 #!/usr/bin/env python
 # -*- coding: utf-8 -*-
 
-from typing import List, Union
+from typing import List, Optional, Union
 import re
 
 from wireviz.DataClasses import Color
 from wireviz.wv_colors import translate_color
 from wireviz.wv_helper import remove_links
 
-def nested_html_table(rows):
+def nested_html_table(rows: List[Union[str, List[Optional[str]], None]], table_attrs: str = '') -> str:
     # input: list, each item may be scalar or list
     # output: a parent table with one child table per parent item that is list, and one cell per parent item that is scalar
     # purpose: create the appearance of one table, where cell widths are independent between rows
     # attributes in any leading <tdX> inside a list are injected into to the preceeding <td> tag
     html = []
-    html.append('<table border="0" cellspacing="0" cellpadding="0">')
+    html.append(f'<table border="0" cellspacing="0" cellpadding="0"{table_attrs or ""}>')
     for row in rows:
         if isinstance(row, List):
             if len(row) > 0 and any(row):
@@ -33,9 +33,13 @@ def nested_html_table(rows):
     html.append('</table>')
     return html
 
+def html_bgcolor_attr(color: Color) -> str:
+    """Return attributes for bgcolor or '' if no color."""
+    return f' bgcolor="{translate_color(color, "HEX")}"' if color else ''
+
 def html_bgcolor(color: Color, _extra_attr: str = '') -> str:
     """Return <td> attributes prefix for bgcolor or '' if no color."""
-    return f'<tdX bgcolor="{translate_color(color, "HEX")}"{_extra_attr}>' if color else ''
+    return f'<tdX{html_bgcolor_attr(color)}{_extra_attr}>' if color else ''
 
 def html_colorbar(color: Color) -> str:
     """Return <tdX> attributes prefix for bgcolor and minimum width or None if no color."""