Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for testCommand if exists #63

Open
henrylee97 opened this issue Nov 29, 2023 · 0 comments
Open

Test for testCommand if exists #63

henrylee97 opened this issue Nov 29, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@henrylee97
Copy link
Member

Currently, smoke tests only perform buildCommand to check if an image is correctly configured to build the benchmark.
But, the repo is collection of bugs, so it would be better if the ci automatically checks the bug can be reproducable.

See

starlab-benchmarks/.github/workflows/check.yml

Line 63 in 76762af

docker run --rm benchmark:latest /bin/bash -c "cd ${{ steps.read-metadata.outputs.location }}; ${{ steps.read-metadata.outputs.buildCommand }}"

@henrylee97 henrylee97 added the enhancement New feature or request label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@henrylee97