Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make target to bump preload version #13158

Closed
medyagh opened this issue Dec 13, 2021 · 6 comments
Closed

Add make target to bump preload version #13158

medyagh opened this issue Dec 13, 2021 · 6 comments
Assignees

Comments

@medyagh
Copy link
Member

medyagh commented Dec 13, 2021

What Happened?

simmilar to when we run
update-golint-version

/~https://github.com/medyagh/minikube/blob/dafc6aa0b07040a21dca7a1755c1dcdaeee686f9/hack/update/golint_version/update_golint_version.go#L27

we should have a make target
make bump-preload

that bumps the preload version by 1

Attach the log file

no

Operating System

No response

Driver

No response

@klaases
Copy link
Contributor

klaases commented Dec 13, 2021

/assign

@medyagh medyagh changed the title auto bump the prelaod version when there is a change in kubeadm consts Add make target to bump preload version Dec 13, 2021
@NikhilSharmaWe
Copy link
Member

NikhilSharmaWe commented Dec 27, 2021

@medyagh the code will be the same as in make update-golint-version or not. If it is the same, why do we need it again with another target name. And if not, what should be the correct code in make bump-preload, to bump version by 1.

Could you please explain.

I am making a PR with target name bump-preload and running update_golint_version.go in it. We can discuss correct way to bump the version by 1 there.

@afbjorklund
Copy link
Collaborator

It is not the same.

@NikhilSharmaWe
Copy link
Member

@afbjorklund Could you provide some guidance how should this functionality be added of bumping the preload version by 1 in make bump-preload.

@afbjorklund
Copy link
Collaborator

afbjorklund commented Dec 28, 2021

I think @klaases is working on it, but maybe @medyagh can explain the feature. I think it's about the preload version. (e.g. 13)

preloaded-images-k8s-v13-v1.22.3-containerd-overlay2-amd64.tar.lz4.download

pkg/minikube/download/preload.go:       // PreloadVersion is the current version of the preloaded tarball
pkg/minikube/download/preload.go:       PreloadVersion = "v16"

@medyagh
Copy link
Member Author

medyagh commented Dec 28, 2021

closed by #13217

@medyagh medyagh closed this as completed Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants