-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OIDC auth refresh flow differs from kubectl behavior #493
Comments
I also ran into this problem when my kubeconfig does not have Ping @yliaog |
i think the patch looks good. idp-certificate-authority-data does not need to be required. could you send a PR? |
… toke refresh, kubernetes-client/python#493 fix pep8 style
… toke refresh, kubernetes-client/python#493 fix pep8 style add unit test
… toke refresh, kubernetes-client/python#493 fix pep8 style add unit test
ping @yliaog. PR is there, any chance for comment/review? |
sorry for late response, i did not get notification about it until you pinged explicitly. the PR looks good. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
… toke refresh, kubernetes-client/python#493 fix pep8 style add unit test
… toke refresh, kubernetes-client/python#493 fix pep8 style add unit test
I've been testing OIDC for authentication using the work done in kubernetes-client/python-base#48 and came across an issue refreshing credentials because I do not specify
idp-certificate-authority-data
in my kubeconfig. This issue has already been brought up: #368 (comment). Askubectl
does not require this key I don't think the python client should either.Another potential issue is the lack of support for the
idp-certificate-authority
key which allows you to load CA certificates from a file. I was attempting to use this to get around the issue mentioned above by loading a trusted root CA bundle. I could convert the entire file to base64 and add it as a value foridp-certificate-authority-data
but this results in an unwieldy kubeconfig file.The text was updated successfully, but these errors were encountered: