-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kube-derive now requires explicit kube-core dependency #525
Comments
Yeah, I missed this point, and don't think we can work around it at the moment. Think we need to make
And possibly having everything but |
Hmmm, sorry about this, I thought I had made this clear in the original PR. |
Yeah, we can probably do the following:
|
As a short-term fix, I've put together #527 which restores the original import, but provides a flag for depending on I imagine that the other proposals will take some time to accomplish, so I figured this short term fix could be useful. |
I appreciate the solution there. I was close to merging it, but figured we could do it the harder way, which is now merged.
Yeah, I had just failed to recognise this point, not your fault. |
released in 0.55.0 |
An unforseen outcome of
kube-core
is that the proc_macro expectskube-core
crate to be available at macro-expansion.This is fine in this workspace (where we use all the crates), but outside, people now need an explicit dependency on
kube-core
, that's NOT intended, and am consider yanking this release :/Tried upgrading `controller-rs``:
The text was updated successfully, but these errors were encountered: