Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calling Object.freeze corrupts null #6

Open
vpulim opened this issue Jan 14, 2011 · 3 comments
Open

calling Object.freeze corrupts null #6

vpulim opened this issue Jan 14, 2011 · 3 comments

Comments

@vpulim
Copy link

vpulim commented Jan 14, 2011

Due to a bug in v8, calling Object.freeze corrupts the global null object. More info: http://groups.google.com/group/nodejs/browse_thread/thread/e205dabc5fcb773e/f578d85ba5da478c
@kriszyp
Copy link
Owner

kriszyp commented Jan 14, 2011

Wow, that's a crazy one. Ok, I'll comment out the freeze.

@kriszyp
Copy link
Owner

kriszyp commented Jan 14, 2011

Wait, this looks like it is already commented out:
/~https://github.com/kriszyp/node-promise/blob/master/promise.js#L56
Am I missing something?

@vpulim
Copy link
Author

vpulim commented Jan 14, 2011

oops, sorry, i think we were using an older version of the code. my apologies...

FYI, version 0.3.0 and above of Node uses a version of v8 that fixes that bug. I tested the latest commit of node-promise with node 0.3.4 and un-commented line 56 and it seems to be working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kriszyp @vpulim