Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to Dead lettered Messages #833

Closed
2 tasks done
gabo1208 opened this issue Jun 23, 2022 · 5 comments
Closed
2 tasks done

Add metadata to Dead lettered Messages #833

gabo1208 opened this issue Jun 23, 2022 · 5 comments

Comments

@gabo1208
Copy link
Contributor

gabo1208 commented Jun 23, 2022

Problem
Messages that fail to be delivered are Dead lettered without any modification, leaving the system/user with no easy way to know why they ended up there. A knative recommendation for this is to add some extra fields in this case that adds that missing info:
https://knative.dev/docs/eventing/event-delivery/#configuring-channel-event-delivery

Persona:
Users

Exit Criteria
Deadlettered messages now have metadata on why they ended up in the DLQ

@gabo1208 gabo1208 changed the title Add metadata to Dead lettered msgs Add metadata to Dead lettered Messages Jun 23, 2022
@gab-satchi gab-satchi added this to the Next milestone Jul 12, 2022
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 11, 2022
@knative-prow-robot
Copy link

This issue or pull request is stale because it has been open for 90 days with no activity.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close

/lifecycle stale

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2022
@andrewwebber
Copy link

Is there any update on this other than it is scheduled for the "next" release?

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2023
@gabo1208 gabo1208 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2023
@gabo1208
Copy link
Contributor Author

Yes @andrewwebber We are finally getting this into Knative RabbitMQ!

We had some issues since is not well supported yet in RabbitMQ but we ended up implementing a solution here meanwhile!

@gabo1208 gabo1208 closed this as completed Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants