feat: add e2e tests #3054

35C4n0r · 2025-01-18T19:34:44Z

Closes #3053

📑 Description

✅ Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

ℹ Additional Information

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

vercel · 2025-01-18T19:34:48Z

@35C4n0r is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

gitguardian · 2025-01-18T19:35:19Z

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}}

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

codecov · 2025-01-19T11:54:31Z

Codecov Report

Attention: Patch coverage is 31.37255% with 105 lines in your changes missing coverage. Please review.

Project coverage is 31.31%. Comparing base (e8cbcb3) to head (755350a).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
tests/e2e_tests/test_grafana_provider.py	29.80%	73 Missing ⚠️
tests/e2e_tests/test_end_to_end.py	27.90%	31 Missing ⚠️
tests/e2e_tests/test_pushing_prometheus_alerts.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3054       +/-   ##
===========================================
- Coverage   43.06%   31.31%   -11.76%     
===========================================
  Files         166       74       -92     
  Lines       16685     8184     -8501     
===========================================
- Hits         7186     2563     -4623     
+ Misses       9499     5621     -3878

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/test-pr-e2e.yml

shahargl · 2025-01-20T11:52:51Z

.github/workflows/test-pr-e2e.yml

          if [ "${{ matrix.db_type }}" == "mysql" ]; then
-            until docker exec $(docker ps -qf "name=keep-database") mysqladmin ping -h "localhost" --silent; do
+            until docker exec $(docker ps -qf "name=keep-database-1") mysqladmin ping -h "localhost" --silent; do


@35C4n0r check, here also keep-database-1 is getting created: /~https://github.com/keephq/keep/actions/runs/12844511458/job/35817583885#step:12:2243

but until docker exec $(docker ps -qf "name=keep-database") pg_isready -h localhost -U keepuser; do /~https://github.com/keephq/keep/actions/runs/12844511458/job/35817583885#step:13:67 still works

shahargl · 2025-01-20T11:53:56Z

tests/e2e_tests/docker-compose-e2e-mysql.yml

@@ -59,5 +138,20 @@ services:
    ports:
      - "9090:9090"

+  grafana:
+    image: grafana/grafana-enterprise:10.4.0


dunno, picked from ./keep/providers/grafana_provider/grafana

tests/e2e_tests/docker-compose-e2e-postgres.yml

shahargl · 2025-01-20T11:54:59Z

tests/e2e_tests/docker-compose-e2e-postgres.yml

@@ -56,5 +132,20 @@ services:
    ports:
      - "9090:9090"

+  grafana:
+    image: grafana/grafana-enterprise:10.4.0


dunno, picked from ./keep/providers/grafana_provider/grafana

Let's go with 11.4.0. "Latest" here will bring instability to our tests.

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

Matvey-Kuk

Great one! A few minor asks

Matvey-Kuk · 2025-01-21T10:57:57Z

.github/workflows/test-pr-e2e.yml

          if [ "${{ matrix.db_type }}" == "mysql" ]; then
-            until docker exec $(docker ps -qf "name=keep-database") mysqladmin ping -h "localhost" --silent; do
+            until docker exec $(docker ps -qf "name=keep-database-1") mysqladmin ping -h "localhost" --silent; do


@35C4n0r check, here also keep-database-1 is getting created: /~https://github.com/keephq/keep/actions/runs/12844511458/job/35817583885#step:12:2243

but until docker exec $(docker ps -qf "name=keep-database") pg_isready -h localhost -U keepuser; do /~https://github.com/keephq/keep/actions/runs/12844511458/job/35817583885#step:13:67 still works

Matvey-Kuk · 2025-01-21T11:02:49Z

tests/e2e_tests/docker-compose-e2e-mysql.yml

+      - NEXTAUTH_URL=http://localhost:3001
+      - NEXT_PUBLIC_API_URL=http://localhost:8081
+      - POSTHOG_KEY=phc_muk9qE3TfZsX3SZ9XxX52kCGJBclrjhkP9JxAQcm1PZ
+      - POSTHOG_HOST=https://ingest.keephq.dev


Please remove POSTHOG keys from here and set POSTHOG_DISABLED=true

Matvey-Kuk · 2025-01-21T11:08:10Z

tests/e2e_tests/docker-compose-e2e-mysql.yml

+      - NEXT_PUBLIC_API_URL=http://localhost:8081
+      - POSTHOG_KEY=phc_muk9qE3TfZsX3SZ9XxX52kCGJBclrjhkP9JxAQcm1PZ
+      - POSTHOG_HOST=https://ingest.keephq.dev
+      - NEXT_PUBLIC_SENTRY_DSN=https://0d4d59e3105ffe8afa27dcb95a222009@o4505515398922240.ingest.us.sentry.io/4508258058764288


Sentry as well, I don't think we need it :)

Matvey-Kuk · 2025-01-21T11:08:25Z

tests/e2e_tests/docker-compose-e2e-postgres.yml

+      - NEXTAUTH_URL=http://localhost:3001
+      - NEXT_PUBLIC_API_URL=http://localhost:8081
+      - POSTHOG_KEY=phc_muk9qE3TfZsX3SZ9XxX52kCGJBclrjhkP9JxAQcm1PZ
+      - POSTHOG_HOST=https://ingest.keephq.dev


This Posthog key too

feat: add e2e tests

e64a456

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Feature A new feature labels Jan 18, 2025

35C4n0r added 5 commits January 19, 2025 01:18

feat: gitpod --> localhost

c7a8b86

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

feat: multiple name instances

24b49dc

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

chore: minor fix

3c3014f

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

chore: minor fix

4df2cc2

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

chore: minor fix

305a59b

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jan 19, 2025

35C4n0r and others added 18 commits January 19, 2025 10:48

chore: minor fix

fc19afd

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

chore: minor fix

b0f4b97

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

chore: minor fix

66a01b2

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

chore: minor fix

56b32db

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

chore: minor fix

7623917

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

chore: fix prom test

6b01805

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

Merge branch 'main' into feat-e2e-tests

b02ca96

Merge branch 'main' into feat-e2e-tests

6e21f22

chore: minor fixes

461742e

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

Merge remote-tracking branch 'origin/feat-e2e-tests' into feat-e2e-tests

3b7d1f4

chore: minor fixes

2b3db30

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

Merge branch 'main' into feat-e2e-tests

3b35ba1

chore: minor fixes

bb82f50

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

chore: minor fixes

58e44ea

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

chore: minor fixes

d3ae308

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

chore: minor fixes

2a3bf9a

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

chore: minor fixes

59bc901

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

Merge branch 'main' into feat-e2e-tests

755350a

shahargl reviewed Jan 20, 2025

View reviewed changes

.github/workflows/test-pr-e2e.yml Outdated Show resolved Hide resolved

shahargl reviewed Jan 20, 2025

View reviewed changes

tests/e2e_tests/docker-compose-e2e-postgres.yml Outdated Show resolved Hide resolved

shahargl reviewed Jan 20, 2025

View reviewed changes

tests/e2e_tests/docker-compose-e2e-postgres.yml Outdated Show resolved Hide resolved

shahargl reviewed Jan 20, 2025

View reviewed changes

35C4n0r added 4 commits January 20, 2025 18:02

chore: minor fixes

bd40c23

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

Merge remote-tracking branch 'origin/feat-e2e-tests' into feat-e2e-tests

73b8cde

chore: minor fixes

a13d273

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

chore: minor fixes

2d23bf3

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

Matvey-Kuk requested changes Jan 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add e2e tests #3054

feat: add e2e tests #3054

35C4n0r commented Jan 18, 2025

vercel bot commented Jan 18, 2025

gitguardian bot commented Jan 18, 2025 •

edited

Loading

codecov bot commented Jan 19, 2025

shahargl Jan 20, 2025

Matvey-Kuk Jan 21, 2025

shahargl Jan 20, 2025

35C4n0r Jan 20, 2025

shahargl Jan 20, 2025

35C4n0r Jan 20, 2025

Matvey-Kuk Jan 21, 2025

Matvey-Kuk left a comment

Matvey-Kuk Jan 21, 2025

Matvey-Kuk Jan 21, 2025

Matvey-Kuk Jan 21, 2025

Matvey-Kuk Jan 21, 2025

feat: add e2e tests #3054

Are you sure you want to change the base?

feat: add e2e tests #3054

Conversation

35C4n0r commented Jan 18, 2025

📑 Description

✅ Checks

ℹ Additional Information

vercel bot commented Jan 18, 2025

gitguardian bot commented Jan 18, 2025 • edited Loading

️✅ There are no secrets present in this pull request anymore.

codecov bot commented Jan 19, 2025

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Matvey-Kuk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gitguardian bot commented Jan 18, 2025 •

edited

Loading