Add feedback in UI when an SSH key gets added to the agent manually (Ctrl-H)

[arigit]

Have you searched for an existing feature request?

• Yes, I tried searching

Brief Summary

Currently, when selecting an option that has an SSH key that is set to be manually added to the agent (via Ctrl-H or context menu selection), there is no UI feedback as to whether this was done or not in the UI.

Request: similarly to what happens when pressing Ctrl-T for the TOTP code where "Clearing clipboard in ... secs" shows up in the status line, can a brief message be displayed in the status line when a key gets added after pressing Ctrl-H?

Example

For example, assuming the entry is set to auto-remove the key from the agent after 1800 seconds:

"SSH Key added to agent, expiring in 1800 seconds"

Or if no expiration but the key is removed after a lock event

"SSH Key added to agent, will be removed when the DB is locked"

etc.

Incidentally, I would also suggest changing the status messages for Ctrl-B, Ctrl-C, Ctrl-T to make them more descriptive, e.g. for Ctrl-T: "TOTP copied to the Clipboard, clearing in .... secs"

Context

No response

[droidmonkey]

The status message shows what is going to happen, not what happened. It is just a simple convenience feature to indicate clipboard clearing will take place. SSH Agent already shows an error message in the UI when a key is not added successfully. I am recommending no changes here.

[arigit]

I didn't know that, that's useful. Just fyi, if I hit Ctrl-H in the wrong entry (happened a few times), with no ssh key in it, no feedback is shown either, hence I thought about this.

To follow the current "show what is going to happen" approach for the status bar, what about showing a temp message saying "Added SSH key expiring in 1800 seconds"? similar to the clipboard one.

[droidmonkey]

We are reserving that space for clipboard clearing only for now. If you end up copying something to clipboard within that timeout then it will replace the ssh message. This just isn't worth the code additions right now.