Add a way to change the METRICS_WATCH_NAMESPACE which further restric… #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the list of namespaces where metrics are collected. Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
wozniakjan
reviewed
Nov 29, 2024
| @@ -31,6 +31,9 @@ agent: | |||
| pullPolicy: IfNotPresent | |||
| imagePullSecrets: [] | |||
|
|
|||
| # comma-separated list of namespaces where pod utilization metrics should be collected | |||
| # or if unset denotes all namespaces, the collecting itself needs to be also enabled by KubernetesMetricsScraping flag | |||
| metricsWatchNamespace: "" | |||
There was a problem hiding this comment.
should we consider adding {{ .Release.Namespace }} by default?
There was a problem hiding this comment.
yep, that's the plan, basically same logic as in keda upstream helm chart
{{- $namespaces := append (splitList "," .Values.agent.metricsWatchNamespace ) .Release.Namespace -}}
{{- range $namespaces }}
...
|
blind merge 🤠 |
jkremser
added a commit
that referenced
this pull request
Dec 5, 2024
#64) Add a way to change the METRICS_WATCH_NAMESPACE which further restrict the list of namespaces where metrics are collected. Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
jkremser
added a commit
that referenced
this pull request
Dec 17, 2024
#64) Add a way to change the METRICS_WATCH_NAMESPACE which further restrict the list of namespaces where metrics are collected. Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
jkremser
added a commit
that referenced
this pull request
Dec 25, 2024
#64) Add a way to change the METRICS_WATCH_NAMESPACE which further restrict the list of namespaces where metrics are collected. Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
jkremser
added a commit
that referenced
this pull request
Dec 27, 2024
#64) Add a way to change the METRICS_WATCH_NAMESPACE which further restrict the list of namespaces where metrics are collected. Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
wozniakjan
pushed a commit
that referenced
this pull request
Jan 2, 2025
#64) Add a way to change the METRICS_WATCH_NAMESPACE which further restrict the list of namespaces where metrics are collected. Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
jkremser
added a commit
that referenced
this pull request
Jan 9, 2025
#64) Add a way to change the METRICS_WATCH_NAMESPACE which further restrict the list of namespaces where metrics are collected. Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: comma must be escaped when passing the values using
--set(if it's in the value file, normal unescaped comma works)