-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extension: allow running without the backend, improve error message #120
Labels
frontend
Related to browser extension
Comments
karlicoss
added a commit
that referenced
this issue
Nov 3, 2020
karlicoss
added a commit
that referenced
this issue
Nov 3, 2020
karlicoss
added a commit
that referenced
this issue
Nov 3, 2020
karlicoss
added a commit
that referenced
this issue
Nov 3, 2020
karlicoss
added a commit
that referenced
this issue
Nov 3, 2020
karlicoss
added a commit
that referenced
this issue
Nov 4, 2020
Some work on it here.. #163 |
Even more work here! #164 |
More work here #165, basically everything that works for backend visits also works for in-browser visits now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment if backend isn't running, user ends up with cryptic "ERROR: Failed to fetch". At the very list, could point to readme and mention they need to run the backend.
In addition, there is some value in running against just local browser history too, so we could be defensive and work with them even without the backend visits. This will require a change somewhere here
Although not sure all queries are possible with local history APIs, but looks doable
For hierarchical queries, this will also require a change to the way visits are treated, at the moment local visits are considered 'boring. Perhaps a toggle to treat certain sources as 'interesting'?
(see https://news.ycombinator.com/item?id=23672393)
The text was updated successfully, but these errors were encountered: