Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v1.30.9-k3s1 and Go 1.22.10 #11618

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

rafaelbreno
Copy link
Contributor

No description provided.

Signed-off-by: Rafael Breno <32229014+rafaelbreno@users.noreply.github.com>
@rafaelbreno rafaelbreno requested a review from a team as a code owner January 16, 2025 02:29
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.69%. Comparing base (be4b1bc) to head (d2d8e7c).
Report is 1 commits behind head on release-1.30.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.30   #11618      +/-   ##
================================================
- Coverage         48.70%   46.69%   -2.01%     
================================================
  Files               185      185              
  Lines             19437    19437              
================================================
- Hits               9466     9076     -390     
- Misses             8582     9040     +458     
+ Partials           1389     1321      -68     
Flag Coverage Δ
e2etests 40.16% <ø> (-3.58%) ⬇️
inttests 18.71% <ø> (ø)
unittests 16.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond
Copy link
Member

Something is broken about your PR branch. Can you rebase it?

@rafaelbreno
Copy link
Contributor Author

@brandond there were no new commits for a rebase, the issue was the flaky CI.

@brandond
Copy link
Member

Hmm, to me the branch shows as not mergable. Are you not seeing this error?

image

@cwayne18
Copy link
Member

That is weird, I don't see it?

image

@rafaelbreno
Copy link
Contributor Author

Also, comparing both branches history the only difference is the newest commit:

Maybe the rebase error is something in GitHub? It doesn't show any details related to the error.

@brandond
Copy link
Member

Weird, I see it on multiple browsers. Glad it's just me though!

@rafaelbreno rafaelbreno merged commit 6d4a309 into k3s-io:release-1.30 Jan 16, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants